Fix: Fix return value of create_forum_topic shortcut - #3381
Merged
Bibo-Joshi merged 2 commits intoNov 23, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
lemontree210
approved these changes
Nov 22, 2022
Copy link
Copy Markdown
Member
|
Just in case: I could also have added the following bit to docstring, but I see that it wasn't done anywhere in shortcut methods for respective methods in Bot. Raises:
:class:`telegram.error.TelegramError`
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@lemontree210 not needed since it's there in the original |
Sorry, something went wrong.
Bibo-Joshi
approved these changes
Nov 22, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick fix, just surprised mypy didn't catch it