FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

API 6.3 for V13 by Poolitzer · Pull Request #3392 · python-telegram-bot/python-telegram-bot · GitHub

/ python-telegram-bot Public

API 6.3 for V13 - #3392

Merged
Bibo-Joshi merged 12 commits into
v13.xfrom
v13.x_api6.3
Dec 6, 2022
ConversationCommits (12)ChecksFiles changed
Merged

API 6.3 for V13#3392
Bibo-Joshi merged 12 commits into
v13.xfrom
v13.x_api6.3

Conversation

Poolitzer commented Nov 25, 2022

Copy link
Copy Markdown
Member

Currently not implemented are the changed/new tests.

I already implemented #3381, if there was another fix related to the 6.3 changes from #3346 I missed that.

github-actions Bot reviewed Nov 25, 2022
View reviewed changes

github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

github-actions Bot reviewed Nov 25, 2022
View reviewed changes

github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hey! Looks like you edited the (dev) requirements or the pre-commit hooks. I'm just a friendly reminder to keep the pre-commit hook versions in sync with the dev requirements and the additional dependencies for the hooks in sync with the requirements :)

harshil21 added ⚙️ bot-api affected functionality: bot-api 🛠 backport change type: backport labels Nov 25, 2022
harshil21 added this to the 13.15 milestone Nov 25, 2022
Bibo-Joshi requested changes Nov 25, 2022
View reviewed changes

Bibo-Joshi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I admire your patience with v13!

Comment thread .pre-commit-config.yaml Outdated
Comment thread docs/source/conf.py Outdated
Comment thread telegram/bot.py Outdated
Comment thread telegram/bot.py Outdated
Comment thread telegram/chatadministratorrights.py Outdated
Comment thread telegram/chatadministratorrights.py Outdated
Comment thread telegram/chatpermissions.py Outdated
Comment thread telegram/chatpermissions.py Outdated
Comment thread telegram/forumtopic.py
Comment thread telegram/forumtopic.py
harshil21 reviewed Nov 26, 2022
View reviewed changes

harshil21 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

great work!

Comment thread docs/source/telegram.forumtopic.rst
Comment thread telegram/bot.py
Comment thread telegram/bot.py Outdated
Comment thread telegram/chatadministratorrights.py
harshil21 added the 📋 pending-reply work status: pending-reply label Nov 27, 2022
Bibo-Joshi approved these changes Dec 4, 2022
View reviewed changes

Bibo-Joshi left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

TBH I didn't go through all changed lines again and also didn't read every single test, but my previous comments where addressed nicely and everything looks in order :) LGTM! Thanks for the PR, Pool!

PS: I'm going to ignore DS on v13 and codacy just complains about this branch not being analyzed - which is fine with me, since it will die soon 🥳

harshil21 approved these changes Dec 4, 2022
View reviewed changes

harshil21 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I also did have a rough look at it, and it looks good to me as well

Bibo-Joshi merged commit d6c6cc2 into v13.x Dec 6, 2022
Bibo-Joshi deleted the v13.x_api6.3 branch December 6, 2022 09:13
github-actions Bot locked and limited conversation to collaborators Dec 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

github-actions[bot] github-actions[bot] left review comments
Bibo-Joshi Bibo-Joshi approved these changes
harshil21 harshil21 approved these changes

Assignees

No one assigned

Labels

🛠 backport change type: backport ⚙️ bot-api affected functionality: bot-api 📋 pending-reply work status: pending-reply

Projects

None yet

Milestone

13.15

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL