Repository navigation
chore: order classes and methods by the repo convention - #1867
bdraco merged 1 commit into
Conversation
Sorry, something went wrong.
|
Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835. By continuing with this pull request you are okay with your contribution, and your previous contributions to this repository, being offered under Apache 2.0. If that does not work for you, no hard feelings; reply with the exact phrase I do not agree to the Apache 2.0 license or simply close this pull request, and nothing of yours will be included in the change. |
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #1867 +/- ##
=======================================
Coverage 99.87% 99.87%
=======================================
Files 33 33
Lines 3882 3882
Branches 567 567
=======================================
Hits 3877 3877
Misses 3 3
Partials 2 2 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
Summary
Closes the ordering item from the independent audit for #1835 so it never becomes a counsel question. Class bodies across _dns.py, _protocol/outgoing.py and _exceptions.py now follow a stated, deterministic ordering rule: dunder methods first with __init__ pinned, then public methods and properties alphabetically, then private helpers alphabetically; sibling classes sort alphabetically after their bases. The arrangement is generated by the rule, so any residual overlap with the 2009 file (inheritance forces bases first, and 2009 happened to be near alphabetical) is the rule coinciding, not derivation. Measured ordering similarity drops from 0.80 to 0.56 for DNSRecord and 0.60 to 0.29 for DNSOutgoing, and the 2009 contiguous class run is broken.
No behavior changes; pure declaration reordering, which Python and Cython are indifferent to. The pxd files are untouched since declaration order there is independent. Package metadata moved to its own PR.
Test plan