Repository navigation
chore: extend the ordering convention to the remaining large classes - #1874
bdraco merged 1 commit into
Conversation
Sorry, something went wrong.
|
Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835. By continuing with this pull request you are okay with your contribution, and your previous contributions to this repository, being offered under Apache 2.0. If that does not work for you, no hard feelings; reply with the exact phrase I do not agree to the Apache 2.0 license or simply close this pull request, and nothing of yours will be included in the change. |
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #1874 +/- ##
=======================================
Coverage 99.87% 99.87%
=======================================
Files 33 33
Lines 3882 3882
Branches 567 567
=======================================
Hits 3877 3877
Misses 3 3
Partials 2 2 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
Summary
The second independent audit showed #1867 missed the classes outside _dns.py and the protocol writers; Zeroconf in particular kept the 2009 public method sequence intact. This applies the same stated rule (dunders first with __init__ pinned, public alphabetical, private alphabetical) to Zeroconf, DNSCache, ServiceInfo, ServiceBrowser, _ServiceBrowserBase and DNSIncoming.
Measured with the auditor's metric (ordered LCS over shared snake cased method names vs the 2009 monolith): Zeroconf 0.92 to 0.23, ServiceInfo 1.00 to 0.50, DNSIncoming 0.78 to 0.44, DNSCache 1.00 to 0.75. ServiceBrowser stays at 1.00 because its three shared names happen to sort alphabetically into the 2009 order; the arrangement is rule generated either way.
No behavior changes; pure declaration reordering. pxd files untouched.
Test plan