Convert projects to SDK style - #1209
Merged
filmor merged 12 commits intoDec 10, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Let's see the build results. If we take this, would need a tracking task for reestablishing testing on Mono. |
Sorry, something went wrong.
lostmsu
reviewed
Aug 25, 2020
Comment thread
setup.py
Outdated
filmor
force-pushed
the
sdk-style
branch
3 times, most recently
from
fbc0376 to
dff8dbe
Compare
September 24, 2020 11:54
- Convert tests to SDK style - Delete obsolete files and add common build props - Convert Runtime to SDK style and always use .NET Standard - Convert console to SDK style - Convert clrmodule to SDK style and switch to NXPorts
filmor
force-pushed
the
sdk-style
branch
6 times, most recently
from
0d3ce21 to
fc6c529
Compare
December 9, 2020 17:51
filmor
marked this pull request as ready for review
December 9, 2020 17:54
Copy link
Copy Markdown
Member
Author
|
There are two tests failing right now, both variants of Python.EmbeddingTest.TestFinalizer.CollectBasicObject. Any idea what could be the reason? |
Sorry, something went wrong.
- Build tests explicitly - Build test fixtures from the pytest call - Run tests with dotnet test - Reset solution file - Always run full test matrix Note: Newer .NET runs Mono tests as well as .NET Core tests if both target frameworks are defined.
filmor
force-pushed
the
sdk-style
branch
2 times, most recently
from
5d3a26c to
640b497
Compare
December 9, 2020 18:55
Copy link
Copy Markdown
Member
Author
|
With the deactivated test, it seems to work now. Not entirely reliably, though. I had some failures in the finalisation. |
Sorry, something went wrong.
lostmsu
reviewed
Dec 9, 2020
Comment thread
pythonnet.15.sln
Comment thread
pythonnet/.gitignore
Comment thread
setup.py
Comment thread
setup.py
Outdated
Comment thread
setup.py
Outdated
Comment thread
src/embed_tests/TestFinalizer.cs
Comment thread
src/monoclr/clrmod.c
Outdated
Comment thread
.github/workflows/main.yml
This was referenced Dec 9, 2020
filmor
commented
Dec 10, 2020
Comment thread
src/embed_tests/TestFinalizer.cs
Copy link
Copy Markdown
Member
Author
|
This is done from my side. |
Sorry, something went wrong.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another attempt, splitting up the conversion to a more modern style even further. This is just supposed to convert the project files and keep the existing loading for now (leaving the new loader for a separate PR based on #1109).