FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Dropped net40 target from modern projects by lostmsu · Pull Request #1300 · pythonnet/pythonnet · GitHub

/ pythonnet Public

Dropped net40 target from modern projects - #1300

Closed
lostmsu wants to merge 2 commits into
pythonnet:masterfrom
losttech:NetStandard
ConversationCommits (2)ChecksFiles changed
Closed

Dropped net40 target from modern projects#1300
lostmsu wants to merge 2 commits into
pythonnet:masterfrom
losttech:NetStandard

Conversation

lostmsu commented Nov 30, 2020

Copy link
Copy Markdown
Member

What does this implement/fix? Explain your changes.

This drops support for .NET Framework 4.0 - 4.6.0. Python.NET will now require .NET Framework 4.6.1+

Does this close any currently open issues?

#1299

Any other comments?

Also removed dead targets for Python 2.X support

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

lostmsu force-pushed the NetStandard branch 4 times, most recently from 48cfa55 to aa20659 Compare November 30, 2020 23:28

codecov-io commented Dec 1, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1300 (aa20659) into master (ab97b02) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1300   +/-   ##
=======================================
  Coverage   87.88%   87.88%           
=======================================
  Files           1        1           
  Lines         289      289           
=======================================
  Hits          254      254           
  Misses         35       35
Flag Coverage Δ
setup_linux 65.05% <ø> (ø)
setup_windows 74.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab97b02...aa20659. Read the comment docs.

lostmsu marked this pull request as ready for review December 1, 2020 00:47

lostmsu commented Dec 1, 2020

Copy link
Copy Markdown
Member Author

Close + reopen to pick up on Travis

lostmsu closed this Dec 1, 2020
lostmsu reopened this Dec 1, 2020

filmor commented Dec 1, 2020

Copy link
Copy Markdown
Member

While I agree with the general sentiment of this PR, I'd like to just land my SDK-style project branch in the next week. It includes this change but changes all of the project files, so this would just lead to a lot of merge conflicts.

lostmsu commented Dec 9, 2020

Copy link
Copy Markdown
Member Author

I will simply rebase my later changes on master once #1209 lands

lostmsu closed this Dec 9, 2020

codecov-commenter commented Sep 28, 2025

Copy link
Copy Markdown

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.73%. Comparing base (ab97b02) to head (8a82bc2).
⚠️ Report is 675 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1300      +/-   ##
==========================================
- Coverage   87.88%   83.73%   -4.16%     
==========================================
  Files           1        1              
  Lines         289      289              
==========================================
- Hits          254      242      -12     
- Misses         35       47      +12
Flag Coverage Δ
setup_linux 59.16% <ø> (-5.89%) ⬇️
setup_windows 73.35% <ø> (-0.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL