| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
As said, while looking mildly prettier, this still renders the library completely useless in this case. I don't think there is any valid reason for us to bail out on init just because a single type is not loaded properly. So, sure, we can merge this, but we can not claim that it fixes the reported issue. |
Sorry, something went wrong.
|
@filmor the fix is the new null check in ShouldBindEvent. The rest is to make it easier to do bug reports: the error data will now at least contain the name of the type that we failed to process. |
Sorry, something went wrong.
|
I see. Still don't see why making ShouldBindEvent special in that it swallows the error instead of throwing is better than just behaving like this uniformly. I'd rather have none of these functions throw, but at least it fixes the reported issue. |
Sorry, something went wrong.
|
@filmor it does not swallow the error. The checks on methods and fields are different. They actually check that method or field was passed, and not just null. In case of event the event itself must exist as well (e.g. not null), but some events apparently do not have a corresponding add method for handlers: AddMethod property is nullable BTW I was unable to reproduce it with C#. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
What does this implement/fix? Explain your changes.
Does this close any currently open issues?
#2405
Checklist
Check all those that are applicable and complete.