FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add null checks before binding by filmor · Pull Request #2406 · pythonnet/pythonnet · GitHub

Repository navigation

Add null checks before binding - #2406

Closed
filmor wants to merge 1 commit into
masterfrom
null-check-before-bind
Closed

filmor wants to merge 1 commit into
masterfrom
null-check-before-bind

Conversation

filmor commented Jun 30, 2024

Copy link
Copy Markdown
Member

No description provided.

Comment on lines -291 to +297
internal static bool ShouldBindMethod(MethodBase mb)
{
return (mb.IsPublic || mb.IsFamily || mb.IsFamilyOrAssembly);
}
internal static bool ShouldBindMethod(MethodBase mb) =>
mb != null &&
(mb.IsPublic || mb.IsFamily || mb.IsFamilyOrAssembly);

internal static bool ShouldBindField(FieldInfo fi)
{
return (fi.IsPublic || fi.IsFamily || fi.IsFamilyOrAssembly);
}
internal static bool ShouldBindField(FieldInfo fi) =>
fi != null &&
(fi.IsPublic || fi.IsFamily || fi.IsFamilyOrAssembly);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Doesn't this just mask issues? I don't remember if we have nullability annotations on, but I think if you want to add a check here, it should throw ArgumentNullException, and instead null should be handled at the call site.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It does mask issues, but in a non-failing way which is a lot better than raising during startup (which effectively renders this library useless). This is an adaptation of what fixes #2405. Throwing an exception here is (apart from having a slightly better stacktrace) effectively the same as leaving the code unchanged.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I mean I suggest to check for null at the call site which is what #2405 (comment) does, and optionally add an argument check in ShouldBindMethod to throw something better than NullReferenceException.

Simply returning false for null inputs is error-prone.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don't agree, but I will also not put any more work into this. If you want to propose a different solution (in code), be my guest.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@filmor opened #2409

filmor commented Jul 2, 2024

Copy link
Copy Markdown
Member Author

Superceded by #2409

filmor closed this Jul 2, 2024
filmor deleted the null-check-before-bind branch October 21, 2025 09:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL