| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Something about CSharpCodeProvider, I'll look into it. It's the same error that @rmadsen-ks had already when he pushed the PR, I think. |
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## master #724 +/- ##
=========================================
Coverage ? 75.58%
=========================================
Files ? 60
Lines ? 5627
Branches ? 888
=========================================
Hits ? 4253
Misses ? 1060
Partials ? 314
Continue to review full report at Codecov.
|
Sorry, something went wrong.
|
@filmor, the only change in this code is optionally calling InitializeEx instead of Initialize. This code is often being touched by tests. The actual change here is really simple, the unit test is excessively complex. Could you consider merging this without a unittest testing CTRL+C explicitly? |
Sorry, something went wrong.
|
I think you are right. I'll merge the PR without the unit test using a merge commit, that way the test is at least present in the history. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
@rmadsen-ks
What does this implement/fix? Explain your changes.
Avoiding overriding signals from the application so that CTRL-C might be handled.
Using Py_InitializeEx(0) (instead Py_Initialize) to avoid overriding signals.
Does this close any currently open issues?
#449 #450
Any other comments?
Just a rebased version of #450.
Checklist
Check all those that are applicable and complete.