FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Minimal Py_IntializeEx change by filmor · Pull Request #777 · pythonnet/pythonnet · GitHub

/ pythonnet Public

Minimal Py_IntializeEx change - #777

Merged
filmor merged 3 commits into
pythonnet:masterfrom
filmor:minimal-initializeex
Nov 15, 2018
ConversationCommits (3)ChecksFiles changed
Merged

Minimal Py_IntializeEx change#777
filmor merged 3 commits into
pythonnet:masterfrom
filmor:minimal-initializeex

Conversation

filmor commented Nov 15, 2018

Copy link
Copy Markdown
Member

What does this implement/fix? Explain your changes.

Minimal version of #724, allows the user to select whether an embedded Python should configure signal handlers or not, defaulting to "false" (which is different from what we had before as a straight call to Py_Initialize will configure signal handlers).

Does this close any currently open issues?

Fixes #449.

Any other comments?

We should follow up on #724 to get a unit test working for this, but this can wait until after 2.4.0.

codecov Bot commented Nov 15, 2018 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #777 into master will decrease coverage by 13.44%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #777       +/-   ##
==========================================
- Coverage   77.04%   63.6%   -13.45%     
==========================================
  Files          63       1       -62     
  Lines        5786     283     -5503     
  Branches      911       0      -911     
==========================================
- Hits         4458     180     -4278     
+ Misses       1024     103      -921     
+ Partials      304       0      -304
Flag Coverage Δ
#setup_linux 63.6% <ø> (-4.95%) ⬇️
#setup_windows ?
Impacted Files Coverage Δ
setup.py 63.6% <0%> (-22.62%) ⬇️
src/runtime/pyansistring.cs
src/runtime/constructorbinder.cs
src/runtime/methodbinder.cs
src/runtime/Util.cs
src/runtime/delegatemanager.cs
src/runtime/eventbinding.cs
src/runtime/pyiter.cs
src/runtime/pynumber.cs
src/runtime/interop27.cs
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c9f035...62634f9. Read the comment docs.

filmor force-pushed the minimal-initializeex branch from 43c56bb to 62634f9 Compare November 15, 2018 12:45
filmor merged commit bf87239 into pythonnet:master Nov 15, 2018
filmor deleted the minimal-initializeex branch November 15, 2018 13:14

den-run-ai commented Nov 15, 2018

Copy link
Copy Markdown
Contributor

@filmor why did you switch both x86 & x64 to AnyCPU?

filmor commented Nov 15, 2018

Copy link
Copy Markdown
Member Author

Argh, sorry, I wanted to exclude this part from the branch :/ I'll revert that particular change.

den-run-ai commented Nov 17, 2018

Copy link
Copy Markdown
Contributor

@filmor py27 got stuck in appveyor for master branch. I restarted the build.

rmadsen-ks mentioned this pull request Feb 13, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

filmor

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Call to Py_Initialize changes signal handler configuration

3 participants

Back | FazBrowse Home | New Git URL