| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
- The callback set by `Runtime.Py_AddPendingCall()` was not being triggered in some cases in a multithreading environment. Replacing it with a `Task`
|
Great, thanks for your continuous efforts to backport fixes, it's highly appreciated. I'll look into merging this before the 2.4 release :) |
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## master #852 +/- ##
==========================================
- Coverage 76.88% 65.3% -11.58%
==========================================
Files 64 1 -63
Lines 5935 294 -5641
Branches 976 0 -976
==========================================
- Hits 4563 192 -4371
+ Misses 1041 102 -939
+ Partials 331 0 -331
Continue to review full report at Codecov.
|
Sorry, something went wrong.
|
The Linux build seems to be fine apart from an unrelated error (happens on master as well). On Windows, however, for some reason this seems to stall, the builds time out during the unit tests. |
Sorry, something went wrong.
|
It trips up the DomainReloadAndGC test, it looks like there is a deadlock in DisposeAll. |
Sorry, something went wrong.
|
If I remove the GIL call from DisposeAll everything works fine as far as I can tell right now. |
Sorry, something went wrong.
|
Great, this looks a lot better, thank you very much :) |
Sorry, something went wrong.
|
@Martin-Molinero Using Py_AddPendingCall is aiming for no Python thread, although we called PyEval_InitThreads at Initialize, but that is a optimize point that we can prevent create a GIL on single thread environment. Also using Py.GIL may create a temporary Python thread state which takes overhead. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
triggered in some cases in a multithreaded environment. Replacing it
with a Task
Changes cherry-picked from Fix memory leak finalizer QuantConnect/pythonnet#29
After

Before
