FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix deadlock when shuting down by Martin-Molinero · Pull Request #30 · QuantConnect/pythonnet · GitHub

Fix deadlock when shuting down - #30

Merged
jaredbroad merged 1 commit into
QuantConnect:masterfrom
Martin-Molinero:fix-deadlock-when-shutting-down
May 29, 2019
Merged

Fix deadlock when shuting down#30
jaredbroad merged 1 commit into
QuantConnect:masterfrom
Martin-Molinero:fix-deadlock-when-shutting-down

Conversation

Martin-Molinero commented May 29, 2019
edited
Loading

Copy link
Copy Markdown
Member

Cherry-picking last commit from PR pythonnet#852 .

Tested executing https://github.com/QuantConnect/Lean Python unit and regression tests and PythonNet unit tests [multiple times].

Copy link
Copy Markdown
Member

Please see if you can pin the threads used to 1 core to confirm low processor environments

Copy link
Copy Markdown
Member Author

Please see if you can pin the threads used to 1 core to confirm low processor environments

The deadlock was reproductible with the python Net unit tests pythonnet#852 (comment) in windows, caused by the using (Py.GIL()) statement

jaredbroad merged commit de514d8 into QuantConnect:master May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL