FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix deprecated import collections by metal3d · Pull Request #253 · rethinkdb/rethinkdb-python · GitHub

/ rethinkdb-python Public

Fix deprecated import collections - #253

Merged
gabor-boros merged 1 commit into
rethinkdb:masterfrom
metal3d:fix-252-abc-import
Sep 29, 2021
ConversationCommits (1)ChecksFiles changed
Merged

Fix deprecated import collections#253
gabor-boros merged 1 commit into
rethinkdb:masterfrom
metal3d:fix-252-abc-import

Conversation

metal3d commented Mar 1, 2021

Copy link
Copy Markdown
Contributor

Replace import collections to import collection.abc for Python >= 3.3

See issue #252

Reason for the change
See #252 for collections deprecation

Description
collections is deprecated, we need to import collections.abc

Note that black made some code fixes (indentation, import order...)

Checklist

References
Anything else related to the change e.g. documentations, RFCs, etc.

metal3d mentioned this pull request Mar 2, 2021
Open

metal3d commented Mar 5, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Afraid that no one continues to support this project...

gabor-boros previously approved these changes Mar 5, 2021
View reviewed changes

metal3d commented Mar 6, 2021

Copy link
Copy Markdown
Contributor Author

👍🏻 @gabor-boros :)

tirkarthi commented Mar 7, 2021

Copy link
Copy Markdown

This was resolved in 2 to 3 branch : #187

tirkarthi reviewed Mar 7, 2021
View reviewed changes
Comment thread rethinkdb/ast.py Outdated
metal3d force-pushed the fix-252-abc-import branch from 4a80a8f to 71112d0 Compare March 7, 2021 10:08
Fix deprecated import collections
13a4107 
Replace import collections to import collection.abc for Python >= 3.3

See issue rethinkdb#252
metal3d force-pushed the fix-252-abc-import branch from 71112d0 to 13a4107 Compare March 7, 2021 10:15
gabor-boros merged commit 424cff7 into rethinkdb:master Sep 29, 2021

gabor-boros commented Sep 29, 2021

Copy link
Copy Markdown
Member

@metal3d Thank you for the contribution! Although a bit late, but approved and merged!

metal3d commented Oct 1, 2021

Copy link
Copy Markdown
Contributor Author

👍🏻 no problem

Inveracity commented Oct 4, 2021

Copy link
Copy Markdown
Contributor

@gabor-boros Now that 3.10 has been released will you cut a new release, please? It would be much appreciated, thank you <3

gabor-boros commented Oct 4, 2021

Copy link
Copy Markdown
Member

@Inveracity a massive refactor coming soon. I'll open the whip PR probably by Wednesday

Inveracity commented Jan 10, 2022

Copy link
Copy Markdown
Contributor

Heya @gabor-boros I'm curious if there has been any progress on the above?
Also is there an official channel for talking about joining the efforts?
I'd be very happy to help

gabor-boros commented May 12, 2022

Copy link
Copy Markdown
Member

@Inveracity Yes, we had some progress, though we are not ready yet with the changes. Feel free to join to Discord or slack and ping me.

srh mentioned this pull request Oct 6, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gabor-boros gabor-boros approved these changes
+1 more reviewer
tirkarthi tirkarthi left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL