up to python 3.10 - #269
Conversation
Sorry, something went wrong.
| if isinstance(val, RqlQuery): | ||
| return val | ||
| elif isinstance(val, collections.Callable): | ||
| elif isinstance(val, collections.abc.Callable): |
There was a problem hiding this comment.
change also needed for collections.Mapping
Sorry, something went wrong.
There was a problem hiding this comment.
This was fixed with #253.
Sorry, something went wrong.
gabor-boros
left a comment
There was a problem hiding this comment.
This PR actually not updates the code to be python 3.10 compatible. Although the net_asyncio is "fixed", I'm not sure that the pinned dependencies, like tornado, supports python 3.10.
Sorry, something went wrong.
| self._parent.host, | ||
| self._parent.port, | ||
| loop=self._io_loop, | ||
| #loop=self._io_loop, droped at py3.10 |
There was a problem hiding this comment.
This makes the driver backward incompatible with older python versions.
Sorry, something went wrong.
There was a problem hiding this comment.
It does? How so? The parameter was optional and otherwise it uses the active loop.
Sorry, something went wrong.
|
Going to close, because, first, this only drops one of the loop parameters (there are a couple more that need to be dropped) and second, the change to collections.abc.Callable should be unnecessary as we rename collections.abc while importing. And PR #296 removes all the loop params that need it. Also, the collections.abc change would break Python <3.3, which we don't want to deliberately break unless it's basically necessary. |
Sorry, something went wrong.
To use with python 3.10 some little changes are necesary.
Callable uses collections.abc
Drop loop arg