FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

up to python 3.10 by dpineiden · Pull Request #269 · rethinkdb/rethinkdb-python · GitHub

/ rethinkdb-python Public

up to python 3.10 #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dpineiden wants to merge 1 commit into from
Conversation 6 Commits 1 Checks 0 Files changed
Closed

up to python 3.10 #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .py  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 1 addition & 1 deletion rethinkdb/ast.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def expr(val, nesting_depth=20):

if isinstance(val, RqlQuery):
return val
elif isinstance(val, collections.Callable):
elif isinstance(val, collections.abc.Callable):

doug-numetric Apr 23, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

change also needed for collections.Mapping

srh Oct 6, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This was fixed with #253.
return Func(val)
elif isinstance(val, (datetime.datetime, datetime.date)):
if not hasattr(val, "tzinfo") or not val.tzinfo:
Expand Down
2 changes: 1 addition & 1 deletion rethinkdb/asyncio_net/net_asyncio.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ def connect(self, timeout):
self._streamreader, self._streamwriter = yield from asyncio.open_connection(
self._parent.host,
self._parent.port,
loop=self._io_loop,
#loop=self._io_loop, droped at py3.10

gabor-boros May 11, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This makes the driver backward incompatible with older python versions.

srh Oct 4, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It does? How so? The parameter was optional and otherwise it uses the active loop.
ssl=ssl_context,
)
self._streamwriter.get_extra_info("socket").setsockopt(
Expand Down
Back | FazBrowse Home | New Git URL