FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add ros2plugin (backport #165) by mergify[bot] · Pull Request #280 · ros/pluginlib · GitHub

/ pluginlib Public

Add ros2plugin (backport #165) - #280

Merged
ahcorde merged 3 commits into
jazzyfrom
mergify/bp/jazzy/pr-165
Oct 9, 2025
Merged

Add ros2plugin (backport #165)#280
ahcorde merged 3 commits into
jazzyfrom
mergify/bp/jazzy/pr-165

Conversation

mergify Bot commented Oct 6, 2025

Copy link
Copy Markdown

Add the plugin command together with the list verb to ros2 CLI.

At the moment it produces the following results:

$ ros2 plugin list
demo_plugin_component:
	Plugin(name='ros2_playground::MessageWriterDerived', type='ros2_playground::MessageWriterDerived', base='ros2_playground::MessageWriter')
rviz_default_plugins:
	Plugin(name='rviz_default_plugins/Camera', type='rviz_default_plugins::displays::CameraDisplay', base='rviz_common::Display')
	Plugin(name='rviz_default_plugins/Grid', type='rviz_default_plugins::displays::GridDisplay', base='rviz_common::Display')
	...

while passing the flag --packages only list packages that export plugins and the relative path to the XML file(s ?),

$ ros2 plugin list --packages
demo_plugin_component:
	share/demo_plugin_component/plugins_description.xml
rviz_default_plugins:
	share/rviz_default_plugins/plugins_description.xml

I'd be more than open to discuss actual output and/or output layout.

Note this does not exactly mimic ROS 1 in terms of prints layout nor in terms of use (yet),
e.g. ROS 1 --> rospack plugins --attrib=plugin <base_package_name>.

Fix ros2/ros2cli#328
Replace ros2/ros2cli#340

Signed-off-by: artivis jeremie.deray@canonical.com


This is an automatic backport of pull request #165 done by Mergify.

Signed-off-by: artivis <jeremie.deray@canonical.com>
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
(cherry picked from commit 1a596d6)

# Conflicts:
#	pluginlib/include/pluginlib/class_desc.hpp
#	pluginlib/include/pluginlib/class_list_macros.hpp
#	pluginlib/include/pluginlib/impl/split.hpp
#	pluginlib/src/list_plugins.cpp
#	pluginlib/test/include/test_base.hpp
#	pluginlib/test/include/test_plugins.hpp
#	pluginlib/test/include/visibility_control.hpp
#	pluginlib/test/test_plugins.cpp
mergify Bot added the conflicts label Oct 6, 2025

mergify Bot commented Oct 6, 2025

Copy link
Copy Markdown
Author

Cherry-pick of 1a596d6 has failed:

On branch mergify/bp/jazzy/pr-165
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit 1a596d6.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   ros2plugin/package.xml
	new file:   ros2plugin/resource/ros2plugin
	new file:   ros2plugin/ros2plugin/__init__.py
	new file:   ros2plugin/ros2plugin/api/__init__.py
	new file:   ros2plugin/ros2plugin/command/__init__.py
	new file:   ros2plugin/ros2plugin/command/plugin.py
	new file:   ros2plugin/ros2plugin/verb/__init__.py
	new file:   ros2plugin/ros2plugin/verb/list.py
	new file:   ros2plugin/setup.py
	new file:   ros2plugin/test/test_copyright.py
	new file:   ros2plugin/test/test_flake8.py
	new file:   ros2plugin/test/test_pep257.py
	new file:   ros2plugin/test/test_xmllint.py

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both added:      pluginlib/include/pluginlib/class_desc.hpp
	both added:      pluginlib/include/pluginlib/class_list_macros.hpp
	both added:      pluginlib/include/pluginlib/impl/split.hpp
	deleted by us:   pluginlib/src/list_plugins.cpp
	deleted by us:   pluginlib/test/include/test_base.hpp
	deleted by us:   pluginlib/test/include/test_plugins.hpp
	both added:      pluginlib/test/include/visibility_control.hpp
	both added:      pluginlib/test/test_plugins.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

mergify Bot mentioned this pull request Oct 6, 2025

ahcorde commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

Pulls: #280
Gist: https://gist.githubusercontent.com/ahcorde/b08cf2d9dd95039fa903b90926f24e8e/raw/91560fef64abfb2f5c8e9f1199b915bdaa55a004/ros2.repos
BUILD args: --packages-above-and-dependencies pluginlib
TEST args: --packages-above pluginlib
ROS Distro: jazzy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17262

  • Linux
  • Linux-aarch64
  • Linux-rhel
  • Windows

ahcorde merged commit b0a2ca8 into jazzy Oct 9, 2025
3 checks passed
ahcorde deleted the mergify/bp/jazzy/pr-165 branch October 9, 2025 12:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL