FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix display.launch.py default model path handling by shreyasathreyav · Pull Request #85 · ros/urdf_tutorial · GitHub

Fix display.launch.py default model path handling - #85

Open
shreyasathreyav wants to merge 1 commit into
ros:ros2from
shreyasathreyav:fix-display-launch-path
Open

shreyasathreyav wants to merge 1 commit into
ros:ros2from
shreyasathreyav:fix-display-launch-path

Conversation

Copy link
Copy Markdown

While running the urdf_tutorial on a newer setup (ROS 2 Kilted on Ubuntu 24.04),
launching the tutorial failed unless the model path was manually prefixed with
urdf/.

The issue was caused by the default model launch argument being constructed
using a PathJoinSubstitution and then stringified. On newer ROS 2 / Python
versions, LaunchArgument defaults are treated strictly as strings, which led to
invalid URDF paths being passed to xacro.

This change:

  • Uses a plain string as the default value for the model argument
  • Prepends the urdf/ directory at the tutorial level when invoking urdf_launch

This keeps urdf_launch generic while fixing the tutorial’s default behavior and
avoids requiring users to manually adjust paths.

Tested on ROS 2 Kilted (Ubuntu 24.04).

Copy link
Copy Markdown
Author

The Ubuntu Noble PR jobs appear to fail during repository checkout (git init fails to execute) before any build or test steps run. This looks like a Jenkins agent issue rather than a code issue. Happy to re-run CI if needed.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL