Fix warnings on Windows. - #2692
Merged
fujitatomoya merged 1 commit intoDec 3, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
For reasons I admit I do not understand, the deprecation warnings for StaticSingleThreadedExecutor on Windows happen when we construct a shared_ptr for it in the tests. If we construct a regular object, then it is fine. Luckily this test does not require a shared_ptr, so just make it a regular object here, which rixes the warning. While we are in here, make all of the tests camel case to be consistent. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Copy link
Copy Markdown
Contributor
Author
|
Pulls: #2692
|
Sorry, something went wrong.
jmachowinski
approved these changes
Dec 3, 2024
fujitatomoya
reviewed
Dec 3, 2024
fujitatomoya
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
lgtm with green CI
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
✅ Backports have been createdDetails
|
Sorry, something went wrong.
mergify Bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
For reasons I admit I do not understand, the deprecation warnings for StaticSingleThreadedExecutor on Windows happen when we construct a shared_ptr for it in the tests. If we construct a regular object, then it is fine. Luckily this test does not require a shared_ptr, so just make it a regular object here, which rixes the warning. While we are in here, make all of the tests camel case to be consistent. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 3310f9e) # Conflicts: # rclcpp/test/rclcpp/executors/test_executors.cpp
ahcorde
pushed a commit
that referenced
this pull request
Dec 4, 2024
* Fix warnings on Windows. (#2692) For reasons I admit I do not understand, the deprecation warnings for StaticSingleThreadedExecutor on Windows happen when we construct a shared_ptr for it in the tests. If we construct a regular object, then it is fine. Luckily this test does not require a shared_ptr, so just make it a regular object here, which rixes the warning. While we are in here, make all of the tests camel case to be consistent. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 3310f9e) # Conflicts: # rclcpp/test/rclcpp/executors/test_executors.cpp * resolve backport conflict. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
HarunTeper
pushed a commit
to HarunTeper/rclcpp
that referenced
this pull request
Dec 9, 2024
For reasons I admit I do not understand, the deprecation warnings for StaticSingleThreadedExecutor on Windows happen when we construct a shared_ptr for it in the tests. If we construct a regular object, then it is fine. Luckily this test does not require a shared_ptr, so just make it a regular object here, which rixes the warning. While we are in here, make all of the tests camel case to be consistent. Signed-off-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: HarunTeper <harun.teper@tu-dortmund.de>
HarunTeper
pushed a commit
to HarunTeper/rclcpp
that referenced
this pull request
Dec 9, 2024
For reasons I admit I do not understand, the deprecation warnings for StaticSingleThreadedExecutor on Windows happen when we construct a shared_ptr for it in the tests. If we construct a regular object, then it is fine. Luckily this test does not require a shared_ptr, so just make it a regular object here, which rixes the warning. While we are in here, make all of the tests camel case to be consistent. Signed-off-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: HarunTeper <harun.teper@tu-dortmund.de>
HarunTeper
pushed a commit
to HarunTeper/rclcpp
that referenced
this pull request
Dec 9, 2024
For reasons I admit I do not understand, the deprecation warnings for StaticSingleThreadedExecutor on Windows happen when we construct a shared_ptr for it in the tests. If we construct a regular object, then it is fine. Luckily this test does not require a shared_ptr, so just make it a regular object here, which rixes the warning. While we are in here, make all of the tests camel case to be consistent. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
HarunTeper
pushed a commit
to HarunTeper/rclcpp
that referenced
this pull request
Mar 3, 2025
For reasons I admit I do not understand, the deprecation warnings for StaticSingleThreadedExecutor on Windows happen when we construct a shared_ptr for it in the tests. If we construct a regular object, then it is fine. Luckily this test does not require a shared_ptr, so just make it a regular object here, which rixes the warning. While we are in here, make all of the tests camel case to be consistent. Signed-off-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: HarunTeper <harun.teper@tu-dortmund.de>
bartalor
pushed a commit
to bartalor/rclcpp
that referenced
this pull request
Jul 15, 2026
For reasons I admit I do not understand, the deprecation warnings for StaticSingleThreadedExecutor on Windows happen when we construct a shared_ptr for it in the tests. If we construct a regular object, then it is fine. Luckily this test does not require a shared_ptr, so just make it a regular object here, which rixes the warning. While we are in here, make all of the tests camel case to be consistent. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For reasons I admit I do not understand, the deprecation warnings for StaticSingleThreadedExecutor on Windows happen when we construct a shared_ptr for it in the tests. If we construct a regular object, then it is fine. Luckily this test does not require a shared_ptr, so just make it a regular object here, which fixes the warning.
While we are in here, make all of the tests camel case to be consistent.
This should fix the warnings introduced by #2683 . @jmachowinski @fujitatomoya FYI