Fix warnings on Windows. (backport #2692) - #2694
Conversation
Sorry, something went wrong.
For reasons I admit I do not understand, the deprecation warnings for StaticSingleThreadedExecutor on Windows happen when we construct a shared_ptr for it in the tests. If we construct a regular object, then it is fine. Luckily this test does not require a shared_ptr, so just make it a regular object here, which rixes the warning. While we are in here, make all of the tests camel case to be consistent. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 3310f9e) # Conflicts: # rclcpp/test/rclcpp/executors/test_executors.cpp
|
Cherry-pick of 3310f9e has failed: On branch mergify/bp/jazzy/pr-2692 Your branch is up to date with 'origin/jazzy'. You are currently cherry-picking commit 3310f9ea. (fix conflicts and run "git cherry-pick --continue") (use "git cherry-pick --skip" to skip this patch) (use "git cherry-pick --abort" to cancel the cherry-pick operation) Unmerged paths: (use "git add <file>..." to mark resolution) both modified: rclcpp/test/rclcpp/executors/test_executors.cpp no changes added to commit (use "git add" and/or "git commit -a") To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Sorry, something went wrong.
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with green CI
Sorry, something went wrong.
|
Pulls: #2694
|
Sorry, something went wrong.
For reasons I admit I do not understand, the deprecation warnings for StaticSingleThreadedExecutor on Windows happen when we construct a shared_ptr for it in the tests. If we construct a regular object, then it is fine. Luckily this test does not require a shared_ptr, so just make it a regular object here, which fixes the warning.
While we are in here, make all of the tests camel case to be consistent.
This should fix the warnings introduced by #2683 . @jmachowinski @fujitatomoya FYI
This is an automatic backport of pull request #2692 done by Mergify.