| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
…lm_values The manifest+environments.yaml -> helm-values mapping in agentex.lib.cli.handlers.deploy_handlers depends only on the stdlib and the agentex.config models, but living in the heavy ADK forced server-side deployers (egp-api-backend) to fork it — and the forks have drifted. Promote the pure mapping to agentex.config.helm_values (slim-safe, same contract as the #396 config-models promotion) and parameterize the consumer differences: repository/image_tag as explicit args, acp_module for pre-resolved ACP modules (filesystem resolution stays in agentex.lib.cli.utils.path_utils). The CLI wrapper keeps its signature, DeploymentError contract, conditional module resolution, and all current policy defaults — behavior-preserving except two before/after-merge debug log lines that no longer fire. Part of AGX1-357. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Sorry, something went wrong.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
What
Promotes the manifest + environments.yaml → helm-values mapping from agentex.lib.cli.handlers.deploy_handlers into a new slim-safe module, agentex.config.helm_values — the same treatment #396 gave the config models. The mapping depends only on the stdlib and the agentex.config models, but living in the heavy ADK forced server-side deployers (egp-api-backend's Temporal deploy workflow) to fork it, and the forks have drifted.
Step 1 of the plan in AGX1-357 (later steps move the policy defaults into the agentex-agent chart; this PR deliberately keeps them).
How the consumer differences are absorbed
Also: BuildContext.dockerignore now declares its default as default=None — pyright doesn't recognize the positional form (the repo lint gate flagged the new tests' BuildContext(...) constructions), and every other optional field in these modules already uses the keyword.
Behavior
Output is unchanged for all callers: same values dict, same defaults (autoscaling, pullPolicy, command injection), same conditional module resolution when helm_overrides provides command. The only observable delta is that two before/after-merge logger.info dumps of the full helm values no longer fire mid-merge (the final "Deploying with the following helm values" log remains); those dumps include env-var values, so they were also dubious to emit from a server.
Slim-safety verified: scripts/check-slim-deps passes, and a differential import check shows agentex.config.helm_values pulls in exactly what agentex.config.agent_manifest already does (no agentex.lib, no yaml/temporalio).
Tests
🧑💻🤖 — posted via Claude Code