fix(cli): make agent autoscaling opt-in instead of a hardcoded default - #498
Closed
mohammadatallah-scale wants to merge 1 commit into
Closed
fix(cli): make agent autoscaling opt-in instead of a hardcoded default#498mohammadatallah-scale wants to merge 1 commit into
mohammadatallah-scale wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
A crash-looping pod's restart CPU burn reads as CPU load, so the HPA this CLI attached to every deployment scaled the failure to maxReplicas, then froze there once the metrics went missing. Keep the autoscaling block so an environments.yaml opt-in still deep-merges onto the existing replica bounds and CPU target. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Pending Mohammad's self-review. This note is removed by a human, not automation.
This CLI gave every deployment an HPA, so a crash-looping pod's restart CPU burn read as load, scaled it to maxReplicas, and froze there. Four of its releases account for 39 of 49 crash-looping pods on dev-sgp.
scaleapi/scaleapi#157885 fixes the same default on the backend cloud-deploy path. This PR is the CLI path.
cc @danielmillerp @RoxyFarhad @smoreinis @MichaelSun48 @declan-scale, this repo has no CODEOWNERS so the PR needs routing.
Test plan
Greptile Summary
The PR makes CLI-generated agent and Temporal worker autoscaling opt-in while retaining default replica and CPU bounds for explicit opt-ins.
Confidence Score: 5/5
The PR appears safe to merge, with the implementation, generated configuration guidance, and tests aligned on autoscaling being disabled unless explicitly enabled.
The recursive Helm-value merge preserves default bounds for partial opt-ins, the agent and Temporal worker remain independently configurable, and no concrete changed-code failure remains.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(cli): make agent autoscaling opt-in ..." | Re-trigger Greptile
Context used: