Feat: read prod_evals and logup_evals from hint in sumcheck_layer_eval - #30
Merged
kunxian-xia merged 4 commits intoJan 29, 2026
Merged
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
2 tasks
Copy link
Copy Markdown
Author
|
We will merge this PR first and then fix the soundness issue in a future PR. |
Sorry, something went wrong.
github-merge-queue Bot
pushed a commit
to scroll-tech/ceno
that referenced
this pull request
Jan 29, 2026
## Summary - [x] rely on scroll-tech/openvm#30. - [x] we read `prod_evals` from hint space inside `NativeSumcheck` chip instead of moving them from hint stream to memory word by word. ### Performance verifying the 6th shard of block `23817600`, the total cells and instructions_executed before and after this PR. | | total cells | instructions_executed | | - | - | - | | before | 2B | 9.5M | | after | 1.3B | 6.7M |
kunxian-xia
pushed a commit
that referenced
this pull request
Feb 9, 2026
* Revert "Feat: read `prod_evals` and `logup_evals` from hint in `sumcheck_layer_eval` (#30)" This reverts commit ef22e8e. * consolidate hint slice changes * debug * debug * fmt * cuda * reduce cell/column usage * restore sumcheck hint ids unit test * fix sumcheck test * put sumcheck hint ids on register * fmt * remove context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary