FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Allow Hint Space Ids for `NativeSumcheck` Inputs by darth-cy · Pull Request #31 · scroll-tech/openvm · GitHub

/ openvm Public
forked from openvm-org/openvm

Allow Hint Space Ids for NativeSumcheck Inputs - #31

Merged
kunxian-xia merged 12 commits into
feat/v1.4.1-scroll-extfrom
feat/sumcheck_flex_hints
Feb 9, 2026
ConversationCommits (12)ChecksFiles changed
Merged

Allow Hint Space Ids for NativeSumcheck Inputs#31
kunxian-xia merged 12 commits into
feat/v1.4.1-scroll-extfrom
feat/sumcheck_flex_hints

Conversation

darth-cy commented Feb 2, 2026 •
edited
Loading

Copy link
Copy Markdown
  • This PR extends the NativeSumcheck opcode's ability to accept hint space Ids for its evaluation inputs.
  • The indicator for this mode of operation is added to the context when calling this opcode.
  • Building upon Feat: read prod_evals and logup_evals from hint in sumcheck_layer_eval #30, this PR ensures the read values are written back to default-initialized witness arrays if the evaluations come from hint space.

kunxian-xia reviewed Feb 3, 2026
View reviewed changes
Comment thread extensions/native/circuit/src/sumcheck/columns.rs Outdated
Comment thread extensions/native/circuit/src/sumcheck/columns.rs Outdated
Comment thread extensions/native/circuit/src/sumcheck/columns.rs Outdated
Comment thread extensions/native/circuit/src/sumcheck/air.rs
Comment thread extensions/native/circuit/src/sumcheck/air.rs
kunxian-xia reviewed Feb 3, 2026
View reviewed changes
Comment thread extensions/native/recursion/tests/sumcheck.rs
let num_prod_evals = num_prod_specs * num_layers * 2;
let prod_spec_evals: Array<C, Ext<C::F, C::EF>> = builder.dyn_array(num_prod_evals);
for idx in 0..num_prod_evals {
let e: Ext<C::F, C::EF> = builder.constant(prod_evals[idx]);

kunxian-xia Feb 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You restored the original test back, it's better to add one more test case to cover the case that evals comes from hint space.

kunxian-xia merged commit 8b4c69f into feat/v1.4.1-scroll-ext Feb 9, 2026
1 of 37 checks passed
kunxian-xia mentioned this pull request Feb 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
kunxian-xia kunxian-xia approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL