| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists. You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file. WalkthroughThis pull request updates dependency versions in the bridge-history-api/go.mod file and bumps the version tag in common/version/version.go. The mod file changes include dependency updates, removals, and additions aimed at aligning package versions. In the version file, the tag is updated from "v4.4.87" to "v4.4.88", reflecting a new release. Additionally, the GitHub Actions workflow for the bridge history API has been modified to provide clearer feedback on uncommitted changes. Changes
Possibly related PRs
Suggested labelsbump-version Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? ❤️ Share 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (.coderabbit.yaml)
Documentation and Community
|
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## develop #1601 +/- ##
========================================
Coverage 51.72% 51.72%
========================================
Files 157 157
Lines 12555 12555
========================================
Hits 6494 6494
Misses 5497 5497
Partials 564 564
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)bridge-history-api/go.mod (1)📜 Review details38-38: Addition of mmap-go Dependency.
A new indirect dependency, github.com/edsrzf/mmap-go v1.0.0, has been introduced. Please ensure that its inclusion is necessary and that its usage (if any) is accompanied by appropriate documentation and testing.
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Reviewing files that changed from the base of the PR and between c07975a and badc313.
⛔ Files ignored due to path filters (1)bridge-history-api/go.mod (9)11-11: Update to go-ethereum Dependency Version.
The version of github.com/scroll-tech/go-ethereum has been updated to v1.10.14-0.20250225152658-bcfdb48dd939, which aligns with the PR's objective to update the L2 geth dependency for Pectra readiness. Please verify that any API changes or incompatibilities introduced by this commit are fully tested.
20-20: Bump Fastcache Version.
The dependency for github.com/VictoriaMetrics/fastcache has been incremented from v1.12.1 to v1.12.2. This minor version bump should be checked to ensure that no regressions or breaking changes have been introduced.
33-33: Pinning golang-set to a Specific Commit.
The dependency github.com/deckarep/golang-set is now fixed at commit v0.0.0-20180603214616-504e848d77ea. Confirm that this specific commit is stable and that its functionality meets the project’s requirements.
55-55: Replacement with hashicorp/golang-lru Dependency.
The dependency github.com/hashicorp/golang-lru is now included at version v0.5.5-0.20210104140557-80c98217689d, replacing github.com/holiman/billy. Verify that this replacement meets the expected functionality and performance characteristics.
86-86: Addition of Prometheus TSDB Dependency.
The dependency github.com/prometheus/tsdb has been added at version v0.7.1. Ensure that its integration with your Prometheus metrics setup is working as intended.
88-88: Update in Notify Library.
The dependency github.com/rjeczalik/notify is now updated to v0.9.1, replacing the previous dependency (github.com/rogpeppe/go-internal). Please verify that the updated notify library fulfills your notification requirements without introducing regressions.
91-91: Update to da-codec Dependency.
The dependency github.com/scroll-tech/da-codec has been updated to v0.1.3-0.20250210041951-d028c537b995. Confirm that this update aligns with compatibility and performance expectations within the project.
116-116: Review npipe Version Pinning.
The dependency gopkg.in/natefinch/npipe.v2 is pinned at v2.0.0-20160621034901-c1b8fa8bdcce. Please double-check if this version is still appropriate for the Windows-specific functionalities, or if an upgrade might be warranted for improved stability or features.
117-117: Multiple Versions of urfave/cli Detected.
Both github.com/urfave/cli/v2 (direct dependency on line 13) and gopkg.in/urfave/cli.v1 (indirect dependency on line 117) are present. Please validate that the indirect dependency on version 1 is necessary and does not conflict with the usage of version 2.
Sorry, something went wrong.
This reverts commit e732acd.
| Back | FazBrowse Home | New Git URL |
Purpose or design rationale of this PR
Updating the dependency of l2geth in bridge-history, supporting set code transactions.
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has tag in common/version.go been updated or have you added bump-version label to this PR?
Breaking change label
Does this PR have the breaking-change label?
Summary by CodeRabbit