Replace removeAttr with removeAttribute. - #6228
Merged
kevin-brown merged 1 commit intoMar 2, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
p8
force-pushed
the
remove-jquery/removeAttr
branch
from
64394cd to
f782fe9
Compare
February 20, 2023 20:23
Copy link
Copy Markdown
Member
|
Can you rebase this with the latest changes on develop (I merged in your PR to fix the CI, thank you!) and back out the dist changes for me? The dist changes cause annoying merge conflicts across PRs so I prefer to recompile it separately after I merge batches of changes. |
Sorry, something went wrong.
This replaces jQuery's `removeAttr` function with the vanilla JavaScript `removeAttribute`. $results, $rendered, $selection and $search all seem to be defined as a single element, so we can call `[0]` to get the element.
p8
force-pushed
the
remove-jquery/removeAttr
branch
from
f782fe9 to
bca4941
Compare
February 21, 2023 20:34
Copy link
Copy Markdown
Contributor
Author
|
@kevin-brown I've rebased and removed the dist changes. |
Sorry, something went wrong.
kevin-brown
approved these changes
Mar 2, 2023
arkonan
added a commit
to modolabs/select2
that referenced
this pull request
May 19, 2023
This reverts commit cd545a4.
kevin-brown
added a commit
that referenced
this pull request
May 26, 2026
- Remove '(unreleased)' marker from the 4.1.0 heading - Add new features: jQuery 4.0.0 support (#6332), originalEvent in close trigger args (#6079) - Add bug fixes: placeholder misalignment (#6277), RTL choice remove button (#6257), digit-only data-placeholder (#6297), AJAX unselection with non-string IDs (#6241, #6335), optgroup child string coercion (#6338) - Add translations: lb (#6131), ug (#6166), ar (#6175), zh-TW (#6157), id (#6153), tr (#6123), ro (#6190), de/es/fr/pt/pt-BR (#6132), pl (#6097, #6377), nb (#6213), fa (#6258), nl (#6269), pt-BR typo (#6200), missing bs/ca/da/fi strings (#6305) - Add miscellaneous: native DOM replacements for jQuery attr/removeAttr (#6227, #6228), classList.add (#6229), jQuery removal from Utils and Translation (#6233), prop() removal (#6289), NPM trusted publishing (#6405)
maxwellfet928
pushed a commit
to maxwellfet928/select2
that referenced
this pull request
Jun 8, 2026
This replaces jQuery's `removeAttr` function with the vanilla JavaScript `removeAttribute`. $results, $rendered, $selection and $search all seem to be defined as a single element, so we can call `[0]` to get the element.
maxwellfet928
pushed a commit
to maxwellfet928/select2
that referenced
this pull request
Jun 8, 2026
- Remove '(unreleased)' marker from the 4.1.0 heading - Add new features: jQuery 4.0.0 support (select2#6332), originalEvent in close trigger args (select2#6079) - Add bug fixes: placeholder misalignment (select2#6277), RTL choice remove button (select2#6257), digit-only data-placeholder (select2#6297), AJAX unselection with non-string IDs (select2#6241, select2#6335), optgroup child string coercion (select2#6338) - Add translations: lb (select2#6131), ug (select2#6166), ar (select2#6175), zh-TW (select2#6157), id (select2#6153), tr (select2#6123), ro (select2#6190), de/es/fr/pt/pt-BR (select2#6132), pl (select2#6097, select2#6377), nb (select2#6213), fa (select2#6258), nl (select2#6269), pt-BR typo (select2#6200), missing bs/ca/da/fi strings (select2#6305) - Add miscellaneous: native DOM replacements for jQuery attr/removeAttr (select2#6227, select2#6228), classList.add (select2#6229), jQuery removal from Utils and Translation (select2#6233), prop() removal (select2#6289), NPM trusted publishing (select2#6405)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes a
The following changes were made
This is related to: #6196