Fixups: post-merge updates related to PR #6241 - #6335
Conversation
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@kevin-brown something about the searching tags does not loose focus integration test seems incompatible with #6241 -- I've commented it out here, and that allows the test suite to pass, but it's not an approach I like so I've moved this into draft status until the problem is figured out. |
Sorry, something went wrong.
|
The problem seems to be that selection:update event handling in the integration tests isn't isolated per-test-case. Some ideas to resolve this:
I attempted to add a QUnit.reset handler from here to achieve the first; but this did not seem to work. The second approach doesn't appear straightforward either; there is no .once(...) function available for event-listener attachment on Select2 instances, nor is there a way to pass {once: true} as a parameter to .on(...). ...so I've slightly-reluctantly implemented the third approach. It doesn't genuinely provide any meaningful runtime isolation between the integration test cases, but it ensure that each event listener should only perform any actions within the scope of its parent test case. |
Sorry, something went wrong.
|
@kevin-brown it's not ideal code (details in my previous message if you're curious), but I believe this is ready for merge. |
Sorry, something went wrong.
|
I'll take the "temporary" hack for now. Thanks for looking into this and documenting your findings! |
Sorry, something went wrong.
- Remove '(unreleased)' marker from the 4.1.0 heading - Add new features: jQuery 4.0.0 support (#6332), originalEvent in close trigger args (#6079) - Add bug fixes: placeholder misalignment (#6277), RTL choice remove button (#6257), digit-only data-placeholder (#6297), AJAX unselection with non-string IDs (#6241, #6335), optgroup child string coercion (#6338) - Add translations: lb (#6131), ug (#6166), ar (#6175), zh-TW (#6157), id (#6153), tr (#6123), ro (#6190), de/es/fr/pt/pt-BR (#6132), pl (#6097, #6377), nb (#6213), fa (#6258), nl (#6269), pt-BR typo (#6200), missing bs/ca/da/fi strings (#6305) - Add miscellaneous: native DOM replacements for jQuery attr/removeAttr (#6227, #6228), classList.add (#6229), jQuery removal from Utils and Translation (#6233), prop() removal (#6289), NPM trusted publishing (#6405)
* Fixup: reference `QUnit.test` instead of relying on global namespace entry Relates-to / merge-resolution-for select2#6241, select2#6334 * Build: recompile distributable files * Tests: temporarily comment-out a failing integration test * Revert "Tests: temporarily comment-out a failing integration test" This reverts commit 1863823. * Tests: isolate `selection:update` integration test event handlers * Cleanup: regenerate NPM lockfile
- Remove '(unreleased)' marker from the 4.1.0 heading - Add new features: jQuery 4.0.0 support (select2#6332), originalEvent in close trigger args (select2#6079) - Add bug fixes: placeholder misalignment (select2#6277), RTL choice remove button (select2#6257), digit-only data-placeholder (select2#6297), AJAX unselection with non-string IDs (select2#6241, select2#6335), optgroup child string coercion (select2#6338) - Add translations: lb (select2#6131), ug (select2#6166), ar (select2#6175), zh-TW (select2#6157), id (select2#6153), tr (select2#6123), ro (select2#6190), de/es/fr/pt/pt-BR (select2#6132), pl (select2#6097, select2#6377), nb (select2#6213), fa (select2#6258), nl (select2#6269), pt-BR typo (select2#6200), missing bs/ca/da/fi strings (select2#6305) - Add miscellaneous: native DOM replacements for jQuery attr/removeAttr (select2#6227, select2#6228), classList.add (select2#6229), jQuery removal from Utils and Translation (select2#6233), prop() removal (select2#6289), NPM trusted publishing (select2#6405)
This pull request includes a
The following changes were made
If this is related to an existing ticket, include a link to it as well.
Relates-to / merge-resolution-for #6241 and #6334.
Edit: add additional fixup descriptions.