FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(deps): update pytest requirement from <8.4,>=6.2.5 to >=6.2.5,<8.5 by dependabot[bot] · Pull Request #1328 · slackapi/bolt-python · GitHub

/ bolt-python Public

chore(deps): update pytest requirement from <8.4,>=6.2.5 to >=6.2.5,<8.5 - #1328

Merged
WilliamBergamin merged 2 commits into
mainfrom
dependabot/pip/pytest-gte-6.2.5-and-lt-8.5
Aug 1, 2025
ConversationCommits (2)ChecksFiles changed
Merged

chore(deps): update pytest requirement from <8.4,>=6.2.5 to >=6.2.5,<8.5#1328
WilliamBergamin merged 2 commits into
mainfrom
dependabot/pip/pytest-gte-6.2.5-and-lt-8.5

Conversation

dependabot Bot commented on behalf of github Jul 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Updates the requirements on pytest to permit the latest version.

Release notes

Sourced from pytest's releases.

8.4.1

pytest 8.4.1 (2025-06-17)

Bug fixes

  • #13461: Corrected _pytest.terminal.TerminalReporter.isatty to support being called as a method. Before it was just a boolean which could break correct code when using -o log_cli=true).

  • #13477: Reintroduced pytest.PytestReturnNotNoneWarning{.interpreted-text role="class"} which was removed by accident in pytest [8.4]{.title-ref}.

    This warning is raised when a test functions returns a value other than None, which is often a mistake made by beginners.

    See return-not-none{.interpreted-text role="ref"} for more information.

  • #13497: Fixed compatibility with Twisted 25+.

Improved documentation

  • #13492: Fixed outdated warning about faulthandler not working on Windows.
Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

dependabot Bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Jul 1, 2025

codecov Bot commented Jul 1, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.96%. Comparing base (beba392) to head (cd44946).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1328   +/-   ##
=======================================
  Coverage   90.96%   90.96%           
=======================================
  Files         222      222           
  Lines        7501     7501           
=======================================
  Hits         6823     6823           
  Misses        678      678

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dependabot Bot force-pushed the dependabot/pip/pytest-gte-6.2.5-and-lt-8.5 branch from 4c92a7d to 38e4aaf Compare July 2, 2025 00:27
zimeg reviewed Jul 2, 2025
View reviewed changes

zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@dependabot LGTM but I am not sure if this should be merged with #1329 🔍

Comment thread requirements/testing_without_asyncio.txt
@@ -1,3 +1,3 @@
# pip install -r requirements/testing_without_asyncio.txt
pytest>=6.2.5,<8.4 # https://github.com/tornadoweb/tornado/issues/3375
pytest>=6.2.5,<8.5 # https://github.com/tornadoweb/tornado/issues/3375

zimeg Jul 2, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🤔 Unsure if this version can remain unbound now that the linked issue is closed?

Suggested change
pytest>=6.2.5,<8.5 # https://github.com/tornadoweb/tornado/issues/3375
pytest>=6.2.5,<8.5

WilliamBergamin Jul 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yess I think we can remove the lower bound requirement, as you mentioned the issue is closed and I think it was for support with python 3.6 but lets keep the upper bound for ease of maintenance

zimeg Jul 7, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@WilliamBergamin Good calls! I found an interesting page on supported versions so opened up another PR to make this change:

🔗 #1333

WilliamBergamin Jul 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sweet 💯 merge away

dependabot Bot force-pushed the dependabot/pip/pytest-gte-6.2.5-and-lt-8.5 branch 2 times, most recently from 5b30e1c to 8f56632 Compare July 2, 2025 16:54
chore(deps): update pytest requirement from <8.4,>=6.2.5 to >=6.2.5,<8.5
ead52e8 
Updates the requirements on [pytest](https://github.com/pytest-dev/pytest) to permit the latest version.
- [Release notes](https://github.com/pytest-dev/pytest/releases)
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst)
- [Commits](pytest-dev/pytest@6.2.5...8.4.1)

---
updated-dependencies:
- dependency-name: pytest
  dependency-version: 8.4.1
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
dependabot Bot force-pushed the dependabot/pip/pytest-gte-6.2.5-and-lt-8.5 branch from 8f56632 to ead52e8 Compare July 2, 2025 19:17

WilliamBergamin commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

We can merge this and deal with #1329 separately

zimeg mentioned this pull request Jul 7, 2025
Merged
4 tasks
WilliamBergamin merged commit df3c426 into main Aug 1, 2025
14 checks passed
WilliamBergamin deleted the dependabot/pip/pytest-gte-6.2.5-and-lt-8.5 branch August 1, 2025 20:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zimeg zimeg left review comments
WilliamBergamin WilliamBergamin approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file python Pull requests that update Python code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL