| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1329 +/- ##
=======================================
Coverage 90.54% 90.54%
=======================================
Files 222 222
Lines 7129 7129
=======================================
Hits 6455 6455
Misses 674 674 ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
Updates the requirements on [pytest-asyncio](https://github.com/pytest-dev/pytest-asyncio) to permit the latest version. - [Release notes](https://github.com/pytest-dev/pytest-asyncio/releases) - [Commits](pytest-dev/pytest-asyncio@v0.1.1...v1.0.0) --- updated-dependencies: - dependency-name: pytest-asyncio dependency-version: 1.0.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate. |
Sorry, something went wrong.
There was a problem hiding this comment.
I've updated this PR so that the async test follow the more classic setup, teardown pattern
Previously this project was using a pytest fixture to configure and return the "event loop". This pattern is not supported by pytest-asyncio 1.x.
Sorry, something went wrong.
There was a problem hiding this comment.
@WilliamBergamin Thanks so much for these improvements to the test suite!
IIRC the event loop was causing frequent warnings and this setup|teardown pattern is nice - LGTM! 👾 ✨
Sorry, something went wrong.
| def get_event_loop(): | ||
| try: | ||
| return asyncio.get_event_loop() | ||
| except RuntimeError as ex: | ||
| if "There is no current event loop in thread" in str(ex): | ||
| loop = asyncio.new_event_loop() | ||
| asyncio.set_event_loop(loop) | ||
| return loop |
There was a problem hiding this comment.
🪓 praise: Farewell the testing event loop in the utils file!
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
⚠️ Dependabot is rebasing this PR ⚠️
Rebasing might not happen immediately, so don't worry if this takes some time.
Note: if you make any changes to this PR yourself, they will take precedence over the rebase.
Updates the requirements on pytest-asyncio to permit the latest version.
Release notesSourced from pytest-asyncio's releases.
CommitsYou can trigger a rebase of this PR by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: