Import module relatively - #163
Closed
liketic wants to merge 1 commit into
Closed
liketic wants to merge 1 commit into
liketic wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
The test failure is caused by test environment issue. @shakeelmohamed Could you please take a review at this PR? It's important to us. Happy to hear your comments. Thanks a lot. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
dears, would you please merge the fixing? Thanks! |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Hi @shakeelmohamed , Please let me know if you have any other concern. Thanks. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Closed in favor of #167, we just need to run some manual tests with modular inputs and custom search commands. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thinks it's a good practise to import internal modules consistently. Now we used relative and absolute import both.