Use relative imports for splunk-sdk - #602
Merged
jramatowski-splunk merged 1 commit intoApr 4, 2025
Merged
jramatowski-splunk merged 1 commit into
jramatowski-splunk merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@maszyk99 any chance you could have a look at this? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@jonathan-s our test pipelines are currently failing, I'm looking into fixing them and after that we should be good to go on merging your changes |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Referencing #163 where there was an effort to use relative imports. There are still some spots where there are not relative imports.
Using relative imports also makes it easier to vendor splunklib.