Fix HTTP 400 errors for certain post requests - #208
Closed
ianpittwood wants to merge 2 commits into
Closed
ianpittwood wants to merge 2 commits into
ianpittwood wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Updated the Support Policy.
Updated documentation for post
Copy link
Copy Markdown
Contributor
|
@sketchypotato - thanks for the (very detailed!) issue report and PR! One quick note - this approach will cause a breaking change, so we're going to take a look at doing this without changing the method signature. |
Sorry, something went wrong.
Closed
Copy link
Copy Markdown
Contributor
|
@ianpittwood thank you for the PR, the issue #207 has been fixed sometime back hence closing this PR |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one possible fix I came up with for issue #207. By moving owner, app, and sharing from arguments to kwargs in the post method, they will be included in the request body. This will fix any 400 errors that result from owner, app, or sharing being left out of REST requests that require them to be explicitly defined in the body of the request.