Possible fix for #207? - #235
Closed
wcastello wants to merge 6 commits into
Closed
wcastello wants to merge 6 commits into
wcastello wants to merge 6 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
When one of the query parameters is, for instance, owner, app or sharing, as when sending a POST request to the + /acl for updating permissions, this call would normally fail because those are stripped out of the actual self.http.post() and used only for self._abspath(). This is a workaround for calling post() with those parameters starting with __. The query dict is then rebuilt stripping the __ so that in the end both self._abspath() and self.http.post() can receive owner, app and sharing arguments.
This access_update() uses service.post() as changed in 0724a3d
Copy link
Copy Markdown
Author
|
Hum, this is breaking now because there are calls like post(__conf=name), would have to think of another prefix or something. |
Sorry, something went wrong.
Use _dup__ as per service.post for app/sharing/owner arguments that need to be sent to http.post()
Copy link
Copy Markdown
Author
|
Ok I'll look into the tests better later to see what's happening but it still seems to be due to the prefix addition/strip. |
Sorry, something went wrong.
my bad, lstrip() clearly doesn't make sense as it takes chars as arguments not a full prefix so 'password'.lstrip('_dup__') == 'assword'
missed .get on self.access for 'sharing'
Copy link
Copy Markdown
Contributor
|
I believe this has been addressed in #352 and now released as https://github.com/splunk/splunk-sdk-python/releases/tag/1.6.15 please upgrade via pip install splunk-sdk==1.6.15 and let us know if you continue to see these issues. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Could anyone please check if this would be ok for fixing #207 ?
Uses __ for service.post() on binding.py for arguments like app, owner, sharing needed for example for post requests to the /acl path for changing permissions and also adds an access_update() to client.py so that the client can transparently call an update in permissions without having to use the __ in the start of those arguments.
At least I believe this approach won't cause a breaking change by changing the method signature as said by @tdhellmann on #208