FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Rename and cleanup follow-up for chunk synchronization by amysutedja · Pull Request #327 · splunk/splunk-sdk-python · GitHub

Repository navigation

Rename and cleanup follow-up for chunk synchronization - #327

Merged
amysutedja merged 1 commit into
developfrom
chunk-synchronization-cleanup
Jun 9, 2020
Merged

amysutedja merged 1 commit into
developfrom
chunk-synchronization-cleanup

Conversation

amysutedja commented Jun 5, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Brief summary of changes:

  • Cleaned up commented-out code
  • Renamed _record_count to pending_record_count and _total_record_count to committed_record_count. The old properties are still callable but produce a deprecated warning. (If you were actually setting those values, you probably shouldn't have been doing that.)
  • RecordWriterV1 now updates committed_record_count before clearing records. Previously it was the other way around, which seems like it would always produce incorrect data.

amysutedja force-pushed the chunk-synchronization-cleanup branch from 9c3c9bc to e740168 Compare June 5, 2020 22:22
Comment thread splunklib/searchcommands/internals.py Resolved
amysutedja merged commit 390d327 into develop Jun 9, 2020
amysutedja deleted the chunk-synchronization-cleanup branch June 9, 2020 19:33
fantavlik mentioned this pull request Jan 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL