Release v1.6.15 - #364
Merged
fantavlik merged 28 commits intoJan 29, 2021
Merged
Release v1.6.15#364fantavlik merged 28 commits into
fantavlik merged 28 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Previously, when an external command used the SCPv2 (chunked=true) protocol via splunklib and returned with 50,000 or more rows for one chunk, it would send two replies intead of one. This caused the external command to get out of sync, sending chunk replies before reading the corresponding request. Fixes #150
Fix deprecation warnings
Update copyright years to 2020
Allow suppying of a key-value body when calling Context.post()
ljiang1
reviewed
Jan 28, 2021
Comment thread
splunklib/searchcommands/internals.py
|
|
||
| # TODO: DVPL-6448: splunklib.searchcommands | Add support for partial: true when it is implemented in | ||
| # ChunkedExternProcessor (See SPL-103525) | ||
| # |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
do we need to remove the bug#?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Do you mean you think the bug has addressed and we can remove this comment? We are OK to refer to ticket numbers as long as we don't provide links if that's the concern.
Sorry, something went wrong.
ljiang1
self-requested a review
January 28, 2021 23:08
ljiang1
approved these changes
Jan 28, 2021
Copy link
Copy Markdown
Contributor
Author
|
FYI there was one failing test which is known to be flaky for 8.x Splunk versions. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fixes
#301 Fix chunk synchronization
#327 Rename and cleanup follow-up for chunk synchronization
#352 Allow supplying of a key-value body when calling Context.post()
Minor changes
#350 Initial end-to-end tests for streaming, reporting, generating custom search commands
#348 Update copyright years to 2020
#346 Readme updates to urls, terminology, and formatting
#317 Fix deprecation warnings