Remove ResultsReader, six - #670
Merged
Ickerday merged 6 commits intoSep 22, 2025
Merged
Ickerday merged 6 commits into
Ickerday merged 6 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was
linked to
issues
Sep 9, 2025
szykol
reviewed
Sep 10, 2025
Comment thread
splunklib/results.py
Resolved
szykol
approved these changes
Sep 10, 2025
Ickerday
force-pushed
the
dev/BJ/SDK-76-remove-deprecation
branch
from
a80249a to
06d332d
Compare
September 15, 2025 14:46
Copy link
Copy Markdown
|
Once this will be released in v2.1.2, |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
@TwilightMercy correct, although we still depend on python-dotenv. |
Sorry, something went wrong.
Copy link
Copy Markdown
Built in in Splunk modules? |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
Any dependencies should be packaged with your Splunk app as described here. Please let us know if you can't find the info you need in the docs. |
Sorry, something went wrong.
This was referenced May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it's high time to get rid of the old ResultsReader. We deprecated it in 1.6.19 (#441), we're at 2.2.0a0 now.
Additionally, I removed the local copy of six and instead added it as an optional dependency group under compat. This might get reverted - ideally we shouldn't be needing this file, but I asked around and there might be issues with removing six entirely because of all apps sharing one interpreter.