FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Upgrade to pgx and pgxpool v5 by connorgorman · Pull Request #4676 · stackrox/stackrox · GitHub

/ stackrox Public

Upgrade to pgx and pgxpool v5 - #4676

Closed
connorgorman wants to merge 1 commit into
masterfrom
cgorman-pgx-5
ConversationCommits (1)ChecksFiles changed
Closed

Upgrade to pgx and pgxpool v5#4676
connorgorman wants to merge 1 commit into
masterfrom
cgorman-pgx-5

Conversation

connorgorman commented Feb 2, 2023

Copy link
Copy Markdown
Contributor

Description

Pick up the latest changes to the pgx library

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

CI

connorgorman requested review from a team, c-du and dashrews78 February 2, 2023 05:46
connorgorman requested a review from a team as a code owner February 2, 2023 05:46

ghost commented Feb 2, 2023

Copy link
Copy Markdown

Images are ready for the commit at 141cda2.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.73.x-649-g141cda2d76.

openshift-ci Bot commented Feb 2, 2023

Copy link
Copy Markdown

@connorgorman: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/go-postgres-tests 141cda2 link true /test go-postgres-tests
ci/prow/gke-postgres-upgrade-tests 141cda2 link false /test gke-postgres-upgrade-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

md2119 commented Feb 2, 2023

Copy link
Copy Markdown
Contributor

I literally did it in one of my PRs because I need this for my search framework enhancements.

md2119 commented Feb 7, 2023

Copy link
Copy Markdown
Contributor

Do we want to upgrade v5 now? Seems like the performance of v5 are inferior to v4. Ref: jackc/pgx#1481

connorgorman commented Feb 13, 2023

Copy link
Copy Markdown
Contributor Author

@md2119

Do we want to upgrade v5 now? Seems like the performance of v5 are inferior to v4. Ref: https://github.com/jackc/pgx/issues/1481

This was on a windows machine. There is an issue resolving arrays which we need to fix. Haven't figured it out yet

connorgorman commented Feb 13, 2023

Copy link
Copy Markdown
Contributor Author

I'm also tempted to just hide this underneath a struct so it's not a 405 line change

janisz commented Jul 13, 2023

Copy link
Copy Markdown
Contributor

Refs:

janisz mentioned this pull request Jul 13, 2023
Closed
5 tasks
janisz mentioned this pull request Nov 6, 2023
Merged
5 tasks
vjwilson deleted the cgorman-pgx-5 branch September 16, 2025 17:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

c-du c-du approved these changes

Assignees

No one assigned

Labels

area/central area/postgres

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL