FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ROX-18154: replace multikey store with single key by janisz · Pull Request #6681 · stackrox/stackrox · GitHub

/ stackrox Public

ROX-18154: replace multikey store with single key - #6681

Merged
janisz merged 1 commit into
masterfrom
master-janisz/06-26-chroe_pg_replace_multikey_store_with_single_key
Jun 28, 2023
ConversationCommits (1)ChecksFiles changed
Merged

ROX-18154: replace multikey store with single key#6681
janisz merged 1 commit into
masterfrom
master-janisz/06-26-chroe_pg_replace_multikey_store_with_single_key

Conversation

janisz commented Jun 26, 2023

Copy link
Copy Markdown
Contributor

Description

It looks like there is no need for multi key stores in production code and the only
usage of multiple key is in TestMultiKeyStruct.
This PR removes second key filed2 and renames the struct to TestStruct.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

CI

openshift-ci Bot commented Jun 26, 2023

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

janisz mentioned this pull request Jun 26, 2023
Merged
5 tasks

janisz commented Jun 26, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

janisz changed the title chroe(pg): replace multikey store with single key chore(pg): replace multikey store with single key Jun 26, 2023

ghost commented Jun 26, 2023 •
edited by ghost
Loading

Copy link
Copy Markdown

Images are ready for the commit at 223468a.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.0.x-811-g223468a6ee.

janisz force-pushed the master-janisz/06-26-chroe_pg_replace_multikey_store_with_single_key branch from 079bb51 to ba4fd1a Compare June 26, 2023 17:35
Base automatically changed from master-janisz/06-26-chroe_pg_remove_unused_legacy_code to master June 26, 2023 17:57
janisz force-pushed the master-janisz/06-26-chroe_pg_replace_multikey_store_with_single_key branch from ba4fd1a to 223468a Compare June 26, 2023 19:15
janisz requested review from md2119 and rhybrillou June 26, 2023 19:16
janisz marked this pull request as ready for review June 26, 2023 19:16
janisz requested a review from a team June 26, 2023 19:16

janisz commented Jun 27, 2023

Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment

janisz commented Jun 27, 2023

Copy link
Copy Markdown
Contributor Author

/retest

openshift-ci Bot commented Jun 27, 2023

Copy link
Copy Markdown

@janisz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-10-qa-e2e-tests 223468a link false /test ocp-4-10-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

dashrews78 reviewed Jun 27, 2023
View reviewed changes
Comment thread proto/storage/test.proto
dashrews78 approved these changes Jun 27, 2023
View reviewed changes

dashrews78 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

one nit about the field name in the struct.

janisz changed the title chore(pg): replace multikey store with single key ROX-18154: replace multikey store with single key Jun 28, 2023
janisz mentioned this pull request Jun 28, 2023
Closed
5 tasks
janisz merged commit 65b92f2 into master Jun 28, 2023
janisz deleted the master-janisz/06-26-chroe_pg_replace_multikey_store_with_single_key branch June 28, 2023 18:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rhybrillou rhybrillou approved these changes
dashrews78 dashrews78 approved these changes
+2 more reviewers
connorgorman connorgorman approved these changes
md2119 md2119 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/postgres

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL