FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ROX-18155: Use generic in pg stores by janisz · Pull Request #6728 · stackrox/stackrox · GitHub

/ stackrox Public

ROX-18155: Use generic in pg stores - #6728

Closed
janisz wants to merge 1 commit into
masterfrom
master-janisz/06-28-ROX-18155_use_generics
ConversationCommits (1)ChecksFiles changed
Closed

ROX-18155: Use generic in pg stores#6728
janisz wants to merge 1 commit into
masterfrom
master-janisz/06-28-ROX-18155_use_generics

Conversation

janisz commented Jun 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR replaces most of generated Postgres stores with generic implementation.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

CI

janisz requested review from a team as code owners June 28, 2023 18:00
This was referenced Jun 28, 2023
Merged
Merged

janisz commented Jun 28, 2023

Copy link
Copy Markdown
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

Base automatically changed from master-janisz/06-26-chroe_pg_replace_multikey_store_with_single_key to master June 28, 2023 18:01
janisz requested a review from a team June 28, 2023 18:01
janisz force-pushed the master-janisz/06-28-ROX-18155_use_generics branch from 4f3d49c to cc226ab Compare June 28, 2023 18:02

ghost commented Jun 28, 2023 •
edited by ghost
Loading

Copy link
Copy Markdown

Images are ready for the commit at cc226ab.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.1.x-233-gcc226ab18b.

openshift-ci Bot commented Jun 28, 2023

Copy link
Copy Markdown

@janisz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-sensor-integration-tests cc226ab link false /test gke-sensor-integration-tests
ci/prow/ocp-4-10-operator-e2e-tests cc226ab link false /test ocp-4-10-operator-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

janisz commented Jun 30, 2023

Copy link
Copy Markdown
Contributor Author

Closing in favour of:

janisz closed this Jun 30, 2023
janisz deleted the master-janisz/06-28-ROX-18155_use_generics branch September 16, 2025 09:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/central area/postgres

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL