FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ROX-18155: pg generic store: cleanup by janisz · Pull Request #6778 · stackrox/stackrox · GitHub

/ stackrox Public

ROX-18155: pg generic store: cleanup - #6778

Merged
janisz merged 2 commits into
masterfrom
master-janisz/06-30-ROX-18155_pg_generic_store_cleanup
Jul 13, 2023
ConversationCommits (2)ChecksFiles changed
Merged

ROX-18155: pg generic store: cleanup#6778
janisz merged 2 commits into
masterfrom
master-janisz/06-30-ROX-18155_pg_generic_store_cleanup

Conversation

janisz commented Jun 30, 2023

Copy link
Copy Markdown
Contributor

Description

A detailed explanation of the changes in your PR.

Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.

In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

janisz requested review from a team as code owners June 30, 2023 16:22
janisz mentioned this pull request Jun 30, 2023
Merged
5 tasks
This was referenced Jun 30, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged

janisz commented Jun 30, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

ghost commented Jun 30, 2023 •
edited by ghost
Loading

Copy link
Copy Markdown

Images are ready for the commit at 2f6a491.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.1.x-391-g2f6a491fb1.

janisz mentioned this pull request Jun 30, 2023
Closed
5 tasks
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch from 3a613cd to e76f62d Compare July 3, 2023 15:48
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_cleanup branch from c3d8279 to 4f44b1e Compare July 3, 2023 15:48
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch from e76f62d to 8916579 Compare July 3, 2023 16:03
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_cleanup branch from 4f44b1e to 111f302 Compare July 3, 2023 16:03
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch 2 times, most recently from a29ea41 to d115aa9 Compare July 4, 2023 13:58
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_cleanup branch from 111f302 to a70ff73 Compare July 4, 2023 13:58
rhybrillou requested changes Jul 5, 2023
View reviewed changes
Comment thread tools/generate-helpers/pg-table-bindings/store.go.tpl Outdated
Comment thread tools/generate-helpers/pg-table-bindings/store.go.tpl Outdated
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch from d115aa9 to 7c359f9 Compare July 6, 2023 11:03
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_cleanup branch from a70ff73 to e5e1c14 Compare July 6, 2023 11:03
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch from 7c359f9 to 76663e1 Compare July 6, 2023 14:16
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_cleanup branch from e5e1c14 to 64188c7 Compare July 6, 2023 14:16
janisz requested a review from rhybrillou July 6, 2023 14:21
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch from 76663e1 to 79fc605 Compare July 6, 2023 15:37
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_cleanup branch from 64188c7 to b3720a4 Compare July 6, 2023 15:37
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch from 79fc605 to e99a02f Compare July 6, 2023 15:47
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_cleanup branch from b3720a4 to 047a6ff Compare July 6, 2023 15:47
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch from e99a02f to e0a2cc6 Compare July 6, 2023 16:34
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_cleanup branch from 047a6ff to 5eabc67 Compare July 6, 2023 16:34
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch from e0a2cc6 to 0f63931 Compare July 7, 2023 12:01
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_cleanup branch from 5eabc67 to 16f8520 Compare July 7, 2023 12:01
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch from 0f63931 to 93c68e3 Compare July 10, 2023 08:11
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_cleanup branch from 16f8520 to 02148b4 Compare July 10, 2023 08:12
This was referenced Jul 12, 2023
Merged
Merged
Merged
Merged
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch from 93c68e3 to dab7621 Compare July 12, 2023 16:59
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_cleanup branch from 02148b4 to 3303ebe Compare July 12, 2023 16:59

janisz commented Jul 13, 2023

Copy link
Copy Markdown
Contributor Author

@janisz started a stack merge that includes this pull request via Graphite.

Base automatically changed from master-janisz/06-30-ROX-18155_pg_generic_store_regions to master July 13, 2023 07:30

janisz commented Jul 13, 2023

Copy link
Copy Markdown
Contributor Author

Graphite rebased this pull request as part of a merge.

janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_cleanup branch from 3303ebe to 2f6a491 Compare July 13, 2023 07:31
janisz merged commit b4c6b8a into master Jul 13, 2023

janisz commented Jul 13, 2023

Copy link
Copy Markdown
Contributor Author

@janisz merged this pull request with Graphite.

janisz deleted the master-janisz/06-30-ROX-18155_pg_generic_store_cleanup branch July 13, 2023 08:40
This was referenced Jul 13, 2023
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rhybrillou rhybrillou approved these changes

Assignees

No one assigned

Labels

area/central area/postgres

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL