FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ROX-18155: pg generic store: GetAll by janisz · Pull Request #6769 · stackrox/stackrox · GitHub

/ stackrox Public

ROX-18155: pg generic store: GetAll - #6769

Merged
janisz merged 1 commit into
masterfrom
master-janisz/06-30-ROX-18155_pg_generic_store_GetAll
Jul 7, 2023
ConversationCommits (1)ChecksFiles changed
Merged

ROX-18155: pg generic store: GetAll#6769
janisz merged 1 commit into
masterfrom
master-janisz/06-30-ROX-18155_pg_generic_store_GetAll

Conversation

janisz commented Jun 30, 2023

Copy link
Copy Markdown
Contributor

Description

A detailed explanation of the changes in your PR.

Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.

In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

janisz requested a review from a team as a code owner June 30, 2023 16:18
This was referenced Jun 30, 2023
Merged
Merged

janisz commented Jun 30, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

This was referenced Jun 30, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged

ghost commented Jun 30, 2023 •
edited by ghost
Loading

Copy link
Copy Markdown

Images are ready for the commit at ffe86f7.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.1.x-330-gffe86f7272.

janisz mentioned this pull request Jun 30, 2023
Closed
5 tasks
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Walk branch from 6ec3701 to c1557dc Compare July 3, 2023 15:47
janisz requested a review from a team as a code owner July 3, 2023 15:47
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetAll branch from 16b5b7d to a6dd70b Compare July 3, 2023 15:47
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Walk branch from c1557dc to 29b04c2 Compare July 3, 2023 16:01
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetAll branch from a6dd70b to 390bc82 Compare July 3, 2023 16:01
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Walk branch from 29b04c2 to 5fb855e Compare July 4, 2023 12:59
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetAll branch from 390bc82 to d6e5a0a Compare July 4, 2023 12:59
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Walk branch from 5fb855e to fe331f0 Compare July 4, 2023 13:22
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetAll branch from d6e5a0a to a315299 Compare July 4, 2023 13:22
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Walk branch from fe331f0 to d78d2af Compare July 4, 2023 13:57
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetAll branch from a315299 to f501f43 Compare July 4, 2023 13:57
rhybrillou approved these changes Jul 5, 2023
View reviewed changes
Comment thread tools/generate-helpers/pg-table-bindings/store.go.tpl
}
{{- end }}

{{- if .GetAll }}

rhybrillou Jul 5, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

If not already done in the cleanup PR, make sure the get-all option is removed from the generator code as well as from the gen.go files that use it.

rhybrillou Jul 6, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The complete cleanup would impact:

  • the gen.go files next to the stores generated by this pull request
  • tools/generate-helpers/pg-table-bindings/migration.go.tpl (or the file could be removed completely, as well as the gen.go file in the migrator)
  • tools/generate-helpers/pg-table-bindings/store.go.tpl (but I think the current pull request already removes all occurrences)
  • tools/generate-helpers/pg-table-bindings/store_test.go.tpl (to let all stores test the GetAll function)
  • tools/generate-helpers/pg-table-bindings/main.go

janisz Jul 6, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

So you think we should expose GetAll method to all stores? I wander what was the reason to have it as optin

janisz Jul 6, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

https://issues.redhat.com/browse/ROX-18312

Comment thread pkg/search/postgres/store.go Outdated
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Walk branch from d78d2af to ad19111 Compare July 6, 2023 11:02
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetAll branch from f501f43 to c14880c Compare July 6, 2023 11:02
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Walk branch from ad19111 to 53be42e Compare July 6, 2023 14:15
janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetAll branch 2 times, most recently from 633cc54 to 96d90a5 Compare July 6, 2023 15:36

openshift-ci Bot commented Jul 6, 2023 •
edited
Loading

Copy link
Copy Markdown

@janisz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-10-operator-e2e-tests 96d90a5 link false /test ocp-4-10-operator-e2e-tests
ci/prow/ocp-4-13-core-bpf-qa-e2e-tests 96d90a5 link false /test ocp-4-13-core-bpf-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

janisz commented Jul 7, 2023

Copy link
Copy Markdown
Contributor Author

@janisz started a stack merge that includes this pull request via Graphite.

Base automatically changed from master-janisz/06-30-ROX-18155_pg_generic_store_Walk to master July 7, 2023 08:07

janisz commented Jul 7, 2023

Copy link
Copy Markdown
Contributor Author

Graphite rebased this pull request as part of a merge.

janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetAll branch from 96d90a5 to ffe86f7 Compare July 7, 2023 08:08
janisz merged commit 87dd8d9 into master Jul 7, 2023

janisz commented Jul 7, 2023

Copy link
Copy Markdown
Contributor Author

@janisz merged this pull request with Graphite.

janisz deleted the master-janisz/06-30-ROX-18155_pg_generic_store_GetAll branch July 7, 2023 09:20
This was referenced Jul 12, 2023
Merged
Merged
Merged
Merged
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rhybrillou rhybrillou approved these changes

Assignees

No one assigned

Labels

area/central area/postgres

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL