ROX-18155: pg generic store: regions by janisz · Pull Request #6777 · stackrox/stackrox · GitHub

Description

A detailed explanation of the changes in your PR.

Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.

Checklist

Investigated and inspected CI test results
Unit test and regression tests added
Evaluated and added CHANGELOG entry if required
Determined and documented upgrade steps
Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.

In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

Current dependencies on/for this PR:

master
- PR ROX-18155: pg generic store: Exists #6766
  - PR ROX-18155: pg generic store: Count #6767
    - PR ROX-18155: pg generic store: Walk #6768
      - PR ROX-18155: pg generic store: GetAll #6769
        
        PR ROX-18155: pg generic store: Get #6770
        
        PR ROX-18155: pg generic store: GetByQuery #6771
        
        PR ROX-18155: pg generic store: GetIDs #6772
        
        PR ROX-18155: pg generic store: GetMany #6773
        
        PR ROX-18155: pg generic store: DeleteByQuery #6774
        PR ROX-18155: pg generic store: Delete #6775
        PR ROX-18155: pg generic store: DeleteMany #6776
        PR ROX-18155: pg generic store: regions #6777 👈
        PR ROX-18155: pg generic store: cleanup #6778
        PR refactor(pg): remove blank lines #6881
        PR ROX-18155: pg generic store: Upsert #6882
        PR WIP: chore(deps): upgrade pgx to v5 #6915
        PR chore(deps): upgrade pgx to v5 #6916
        
        PR refactor(pg): preallocate memory when copy #6894
        PR ROX-18391: cleanup permission checker #6907

This comment was auto-generated by Graphite.

Images are ready for the commit at dab7621.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.1.x-382-gdab7621898.

I think some of the changes that are showing here should not actually be part of this PR.
Please make sure that the only changes here are those linked to the use of regions in the store template and in the generated files.

@janisz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/ocp-4-13-qa-e2e-tests	0f63931	link	false	/test ocp-4-13-qa-e2e-tests
ci/prow/ocp-4-13-core-bpf-qa-e2e-tests	0f63931	link	false	/test ocp-4-13-core-bpf-qa-e2e-tests
ci/prow/ocp-4-13-operator-e2e-tests	0f63931	link	false	/test ocp-4-13-operator-e2e-tests
ci/prow/ocp-4-10-qa-e2e-tests	0f63931	link	false	/test ocp-4-10-qa-e2e-tests
ci/prow/ocp-4-10-operator-e2e-tests	0f63931	link	false	/test ocp-4-10-operator-e2e-tests
ci/prow/ocp-4-10-sensor-integration-tests	0f63931	link	false	/test ocp-4-10-sensor-integration-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@janisz started a stack merge that includes this pull request via Graphite.

@janisz merged this pull request with Graphite.

janisz requested review from a team as code owners June 30, 2023 16:21

github-actions Bot added area/central area/postgres labels Jun 30, 2023

janisz mentioned this pull request Jun 30, 2023

ROX-18155: pg generic store: cleanup #6778

Merged

5 tasks

janisz mentioned this pull request Jun 30, 2023

ROX-18155: Use generic in pg stores #6728

Closed

5 tasks

janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_DeleteMany branch from 824f44b to f1a9c46 Compare July 3, 2023 15:48

janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch from 3a613cd to e76f62d Compare July 3, 2023 15:48

janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_DeleteMany branch from f1a9c46 to 9d57793 Compare July 3, 2023 16:03

janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch from e76f62d to 8916579 Compare July 3, 2023 16:03

janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_DeleteMany branch from 9d57793 to bd89a22 Compare July 4, 2023 13:00

janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch from 8916579 to a29ea41 Compare July 4, 2023 13:00

janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_DeleteMany branch from bd89a22 to fb26e10 Compare July 4, 2023 13:58

janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch from a29ea41 to d115aa9 Compare July 4, 2023 13:58

rhybrillou requested changes Jul 5, 2023

View reviewed changes

Comment thread pkg/search/postgres/store.go Outdated

janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_DeleteMany branch from fb26e10 to c7cc82f Compare July 6, 2023 11:02

janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch from d115aa9 to 7c359f9 Compare July 6, 2023 11:03

janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_DeleteMany branch from c7cc82f to 45a3aeb Compare July 6, 2023 14:16

janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch from 7c359f9 to 76663e1 Compare July 6, 2023 14:16

janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_DeleteMany branch from 45a3aeb to b623261 Compare July 6, 2023 15:37

janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch from 76663e1 to 79fc605 Compare July 6, 2023 15:37

janisz requested a review from rhybrillou July 6, 2023 15:45

janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_DeleteMany branch from b623261 to 889ba77 Compare July 6, 2023 15:47

janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch 2 times, most recently from e99a02f to e0a2cc6 Compare July 6, 2023 16:34

janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_DeleteMany branch from 889ba77 to 7e60fa5 Compare July 7, 2023 12:01

janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch from e0a2cc6 to 0f63931 Compare July 7, 2023 12:01

janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_DeleteMany branch from 7e60fa5 to 8dde6f5 Compare July 7, 2023 19:25

Base automatically changed from master-janisz/06-30-ROX-18155_pg_generic_store_DeleteMany to master July 7, 2023 20:54

janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch from 0f63931 to 93c68e3 Compare July 10, 2023 08:11

rhybrillou approved these changes Jul 10, 2023

View reviewed changes

This was referenced Jul 12, 2023

refactor(pg): remove blank lines #6881

Merged

ROX-18155: pg generic store: Upsert #6882

Merged

refactor(pg): preallocate memory when copy #6894

Merged

ROX-18391: cleanup permission checker #6907

Merged

ROX-18155 : pg generic store: regions

dab7621

janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch from 93c68e3 to dab7621 Compare July 12, 2023 16:59

janisz merged commit 4c16e97 into master Jul 13, 2023

janisz deleted the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch July 13, 2023 07:30

This was referenced Jul 13, 2023

WIP: chore(deps): upgrade pgx to v5 #6915

Closed

chore(deps): upgrade pgx to v5 #6916

Merged

ROX-18155: pg generic store: regions by janisz · Pull Request #6777 · stackrox/stackrox · GitHub

Uh oh!

ROX-18155: pg generic store: regions - #6777

ROX-18155: pg generic store: regions#6777
janisz merged 1 commit into
masterfrom
master-janisz/06-30-ROX-18155_pg_generic_store_regions

janisz commented Jun 30, 2023

Uh oh!

janisz commented Jun 30, 2023 •
edited
Loading

Uh oh!

Uh oh!

ghost commented Jun 30, 2023 •
edited by ghost
Loading

Uh oh!

Uh oh!

rhybrillou left a comment

Uh oh!

Uh oh!

openshift-ci Bot commented Jul 7, 2023 •
edited
Loading

Uh oh!

Uh oh!

janisz commented Jul 13, 2023

Uh oh!

janisz commented Jul 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ROX-18155: pg generic store: regions by janisz · Pull Request #6777 · stackrox/stackrox · GitHub

Uh oh!

ROX-18155: pg generic store: regions - #6777

ROX-18155: pg generic store: regions#6777janisz merged 1 commit intomasterstackrox/stackrox:masterfrom master-janisz/06-30-ROX-18155_pg_generic_store_regionsstackrox/stackrox:master-janisz/06-30-ROX-18155_pg_generic_store_regionsCopy head branch name to clipboard

Conversation

janisz commented Jun 30, 2023

Description

Checklist

Testing Performed

Uh oh!

janisz commented Jun 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jun 30, 2023 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rhybrillou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

openshift-ci Bot commented Jul 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

janisz commented Jul 13, 2023

Uh oh!

janisz commented Jul 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ROX-18155: pg generic store: regions#6777
janisz merged 1 commit into
masterfrom
master-janisz/06-30-ROX-18155_pg_generic_store_regions

janisz commented Jun 30, 2023 •
edited
Loading

ghost commented Jun 30, 2023 •
edited by ghost
Loading

openshift-ci Bot commented Jul 7, 2023 •
edited
Loading