| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
I'm for this but let's merge it after the current release in two weeks so we have a cycle to see if anything breaks (though I think this should be a fine change) |
Sorry, something went wrong.
|
Absolutely! There's no rush. I just had time and wanted to work on it. I'm relying on the CI machinery. |
Sorry, something went wrong.
|
(It should definitely go after the release is done.) |
Sorry, something went wrong.
|
Once the merge conflict is resolved I'm cool approving this and merging it to the 5.0 branch. Once the 5.0 branch has another PR in it let's open a PR up for it so the tests go off for the 5.0 branch |
Sorry, something went wrong.
|
Just fixed the merge conflict. The 5.0 branch doesn't have continuous integration in place, unfortunately. |
Sorry, something went wrong.
|
Lets start merging to it and open a PR for the 5.0 branch |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Summary
This PR removes all the deprecated _log() probability functions.
As a consequence, many of the tests needed to be updated.
Tests
I tried to catch all the tests and update them appropiately.
All the log_matches_lpdf and log_matches_lpmf tests are now gone!
Side Effects
This is a breaking change since functions that existed are now removed.
Release notes
Removing deprecated _log distribution functions. Please use _lpdf or _lpmf functions instead.
Checklist
Copyright holder: Daniel Lee
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested