5.0 breaking changes by SteveBronder · Pull Request #3050 · stan-dev/math · GitHub

Summary

Ongoing 5.0 branch that contains breaking changes. This should be merged after the coming release so we have a whole release cycle to track down any possible bugs

Contains:

Add any PRs to the above that should be in the 5.0 release

Release notes

Updates Stan math to 5.0

Checklist

Copyright holder: Simon's Foundation, Daniel Lee, Sean Pinkney

The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
- unit tests pass (to run, use: ./runTests.py test/unit)
- header checks pass, (make test-headers)
- dependencies checks pass, (make test-math-dependencies)
- docs build, (make doxygen)
- code passes the built in C++ standards checks (make cpplint)
the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested

…e-move-semantics' into feature/reverse-mode-move-semantics

…de-move-semantics

…-dev/math into feature/reverse-mode-move-semantics

…de-move-semantics

@syclik should we also remove the cdf_log etc functions?

…ics' into feature/reverse-mode-move-semantics

Name	Old Result	New Result	Ratio	Performance change( 1 - new / old )
arma/arma.stan	0.23	0.26	0.87	-14.85% slower
low_dim_corr_gauss/low_dim_corr_gauss.stan	0.01	0.01	0.95	-4.95% slower
gp_regr/gen_gp_data.stan	0.02	0.02	0.98	-1.94% slower
gp_regr/gp_regr.stan	0.11	0.11	1.02	1.54% faster
sir/sir.stan	78.01	77.85	1.0	0.2% faster
irt_2pl/irt_2pl.stan	3.83	4.66	0.82	-21.66% slower
eight_schools/eight_schools.stan	0.05	0.05	0.99	-1.14% slower
pkpd/sim_one_comp_mm_elim_abs.stan	0.25	0.26	0.97	-3.49% slower
pkpd/one_comp_mm_elim_abs.stan	18.05	18.53	0.97	-2.67% slower
garch/garch.stan	0.47	0.45	1.05	4.95% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan	2.8	2.77	1.01	1.36% faster
arK/arK.stan	1.63	1.64	1.0	-0.18% slower
gp_pois_regr/gp_pois_regr.stan	2.57	2.51	1.03	2.6% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan	9.12	8.96	1.02	1.71% faster
performance.compilation	176.09	181.52	0.97	-3.09% slower
Mean result: 0.9767553035904566

Jenkins Console Log
Blue Ocean
Commit hash: ffae22a76851e3b49ca43f31234eeada692f1d9b

Machine information No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 80
On-line CPU(s) list: 0-79
Thread(s) per core: 2
Core(s) per socket: 20
Socket(s): 2
NUMA node(s): 2
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz
Stepping: 4
CPU MHz: 2400.000
CPU max MHz: 3700.0000
CPU min MHz: 1000.0000
BogoMIPS: 4800.00
Virtualization: VT-x
L1d cache: 1.3 MiB
L1i cache: 1.3 MiB
L2 cache: 40 MiB
L3 cache: 55 MiB
NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78
NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: KVM: Mitigation: VMX disabled
Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Retbleed: Mitigation; IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; IBRS, IBPB conditional, STIBP conditional, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke md_clear flush_l1d arch_capabilities

G++:
g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Clang:
clang version 10.0.0-4ubuntu1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

@syclik should we also remove the cdf_log etc functions?

Definitely! Let me see what's left on the 5.0 branch.

(I think the answer is all of them are still on the branch.)

…de-move-semantics

Name	Old Result	New Result	Ratio	Performance change( 1 - new / old )
arma/arma.stan	0.19	0.18	1.05	4.85% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan	0.01	0.01	1.05	4.4% faster
gp_regr/gen_gp_data.stan	0.02	0.02	1.03	3.27% faster
gp_regr/gp_regr.stan	0.11	0.1	1.05	4.5% faster
sir/sir.stan	77.07	74.51	1.03	3.32% faster
irt_2pl/irt_2pl.stan	4.01	3.78	1.06	5.66% faster
eight_schools/eight_schools.stan	0.05	0.05	1.01	1.3% faster
pkpd/sim_one_comp_mm_elim_abs.stan	0.25	0.25	0.98	-2.1% slower
pkpd/one_comp_mm_elim_abs.stan	18.34	17.74	1.03	3.24% faster
garch/garch.stan	0.46	0.44	1.05	4.87% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan	2.76	2.72	1.01	1.48% faster
arK/arK.stan	1.66	1.6	1.04	4.1% faster
gp_pois_regr/gp_pois_regr.stan	2.51	2.46	1.02	2.17% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan	9.09	8.87	1.02	2.42% faster
performance.compilation	176.14	176.52	1.0	-0.22% slower
Mean result: 1.0301341785445157

Jenkins Console Log
Blue Ocean
Commit hash: 13017193216fe150e9a8fadbc7b3f9cb71f8a58d

Machine information No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 80
On-line CPU(s) list: 0-79
Thread(s) per core: 2
Core(s) per socket: 20
Socket(s): 2
NUMA node(s): 2
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz
Stepping: 4
CPU MHz: 2400.000
CPU max MHz: 3700.0000
CPU min MHz: 1000.0000
BogoMIPS: 4800.00
Virtualization: VT-x
L1d cache: 1.3 MiB
L1i cache: 1.3 MiB
L2 cache: 40 MiB
L3 cache: 55 MiB
NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78
NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: KVM: Mitigation: VMX disabled
Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Retbleed: Mitigation; IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; IBRS, IBPB conditional, STIBP conditional, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke md_clear flush_l1d arch_capabilities

G++:
g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Clang:
clang version 10.0.0-4ubuntu1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

…ntics Allow arena_matrix to use move semantics

@syclik the release is finished. Should we merge this once all the tests pass?

Name	Old Result	New Result	Ratio	Performance change( 1 - new / old )
arma/arma.stan	0.32	0.4	0.81	-22.97% slower
low_dim_corr_gauss/low_dim_corr_gauss.stan	0.01	0.01	0.88	-14.12% slower
gp_regr/gen_gp_data.stan	0.02	0.02	0.99	-1.02% slower
gp_regr/gp_regr.stan	0.1	0.1	1.03	2.48% faster
sir/sir.stan	71.88	70.96	1.01	1.28% faster
irt_2pl/irt_2pl.stan	4.06	4.32	0.94	-6.4% slower
eight_schools/eight_schools.stan	0.06	0.06	1.08	7.75% faster
pkpd/sim_one_comp_mm_elim_abs.stan	0.25	0.25	1.0	0.05% faster
pkpd/one_comp_mm_elim_abs.stan	19.73	19.09	1.03	3.28% faster
garch/garch.stan	0.45	0.42	1.07	6.58% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan	2.75	2.61	1.06	5.3% faster
arK/arK.stan	1.82	1.74	1.05	4.75% faster
gp_pois_regr/gp_pois_regr.stan	2.9	2.77	1.05	4.41% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan	8.82	8.41	1.05	4.63% faster
performance.compilation	187.45	180.43	1.04	3.75% faster
Mean result: 1.0057288202839376

Jenkins Console Log
Blue Ocean
Commit hash: 8faf1b348dbabeb7810ec008d194722ee9cb2c26

Machine information No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 80
On-line CPU(s) list: 0-79
Thread(s) per core: 2
Core(s) per socket: 20
Socket(s): 2
NUMA node(s): 2
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz
Stepping: 4
CPU MHz: 2400.000
CPU max MHz: 3700.0000
CPU min MHz: 1000.0000
BogoMIPS: 4800.00
Virtualization: VT-x
L1d cache: 1.3 MiB
L1i cache: 1.3 MiB
L2 cache: 40 MiB
L3 cache: 55 MiB
NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78
NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: KVM: Mitigation: VMX disabled
Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Retbleed: Mitigation; IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; IBRS, IBPB conditional, STIBP conditional, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke md_clear flush_l1d arch_capabilities

G++:
g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Clang:
clang version 10.0.0-4ubuntu1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

Yes! We should!

Cool! Since I opened the PR can you approve?

Name	Old Result	New Result	Ratio	Performance change( 1 - new / old )
arma/arma.stan	0.36	0.36	1.01	0.52% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan	0.01	0.01	0.98	-2.05% slower
gp_regr/gen_gp_data.stan	0.02	0.02	1.01	1.47% faster
gp_regr/gp_regr.stan	0.11	0.11	1.01	0.56% faster
sir/sir.stan	77.05	75.83	1.02	1.58% faster
irt_2pl/irt_2pl.stan	4.86	4.93	0.99	-1.49% slower
eight_schools/eight_schools.stan	0.07	0.06	1.21	17.58% faster
pkpd/sim_one_comp_mm_elim_abs.stan	0.26	0.27	0.98	-2.25% slower
pkpd/one_comp_mm_elim_abs.stan	21.3	21.72	0.98	-1.95% slower
garch/garch.stan	0.53	0.5	1.06	5.55% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan	2.97	2.86	1.04	3.67% faster
arK/arK.stan	1.96	1.86	1.06	5.27% faster
gp_pois_regr/gp_pois_regr.stan	3.13	2.94	1.06	6.04% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan	9.65	9.52	1.01	1.35% faster
performance.compilation	202.17	210.53	0.96	-4.14% slower
Mean result: 1.0246619299492719

Jenkins Console Log
Blue Ocean
Commit hash: 8faf1b348dbabeb7810ec008d194722ee9cb2c26

Machine information No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 80
On-line CPU(s) list: 0-79
Thread(s) per core: 2
Core(s) per socket: 20
Socket(s): 2
NUMA node(s): 2
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz
Stepping: 4
CPU MHz: 2400.000
CPU max MHz: 3700.0000
CPU min MHz: 1000.0000
BogoMIPS: 4800.00
Virtualization: VT-x
L1d cache: 1.3 MiB
L1i cache: 1.3 MiB
L2 cache: 40 MiB
L3 cache: 55 MiB
NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78
NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: KVM: Mitigation: VMX disabled
Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Retbleed: Mitigation; IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; IBRS, IBPB conditional, STIBP conditional, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke md_clear flush_l1d arch_capabilities

G++:
g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Clang:
clang version 10.0.0-4ubuntu1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

LGTM! I spot-checked the code and it looks just as I expected it to be (from previous reviews).

@SteveBronder, thank you for shepherding this PR all the way through to completion!

@SteveBronder, I'm going to merge the PR now just so we can get it flowing through the automatic testing on develop.

SteveBronder and others added 30 commits August 1, 2023 18:11

Adds move semantics for arena matrix types

00a9f43

use forwarding in sum

056e297

add docs related to auto dangers with the math library

3a6c11e

add docs related to auto dangers with the math library

fa8a464

[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1

3f07884

newline

e5e226b

Merge remote-tracking branch 'refs/remotes/origin/feature/reverse-mod…

d66673b

…e-move-semantics' into feature/reverse-mode-move-semantics

[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1

53dc399

fix constructor alias bug

fcca84d

Merge remote-tracking branch 'refs/remotes/origin/feature/reverse-mod…

c13855f

…e-move-semantics' into feature/reverse-mode-move-semantics

[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1

2f42a0a

fix normal_lpdf templates

4189367

Merge remote-tracking branch 'refs/remotes/origin/feature/reverse-mod…

b297df5

…e-move-semantics' into feature/reverse-mode-move-semantics

[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1

5b76fc8

fix transpose issues with arena matrix

5fbaf55

Merge remote-tracking branch 'origin/develop' into feature/reverse-mo…

1bfd431

…de-move-semantics

[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1

119099d

cleanup after reduce_sum is called in tests

90b23ab

[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1

9ce5c50

remove tmp sundials files

1871c64

Merge branch 'feature/reverse-mode-move-semantics' of github.com:stan…

42cef50

…-dev/math into feature/reverse-mode-move-semantics

use agradrev in mix/probs test

0ec5253

use forwarding in normal_lpdf functions

d6b892d

Merge commit 'd4eab2773347ca6fbe03d49f70828c08ff248269' into HEAD

984bdf8

[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1

a85e786

fix typo

1b0504a

Merge remote-tracking branch 'origin/develop' into feature/reverse-mo…

4f926cf

…de-move-semantics

update docs

0d34e03

removing deprecated _log() probability functions

0b49a28

updating tests that called _log() probability functions

30d1181

SteveBronder and others added 4 commits April 18, 2024 12:51

update header includes for var_test

a604fa4

ad require_not_arena_matrix_t

6a71cfb

[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1

a2124c1

Merge remote-tracking branch 'origin/develop' into 5.0-breaking-changes

7881af5

SteveBronder and others added 7 commits April 18, 2024 13:34

remove wiener_log function

a035f62

fix definition of require_not_arena_matrix_t

1e906d9

fix definition of require_not_arena_matrix_t

de7d11e

Merge remote-tracking branch 'origin/feature/reverse-mode-move-semant…

d89610e

…ics' into feature/reverse-mode-move-semantics

merge

eee02d8

[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1

c5f983a

fix test that used _log function

00314f3

SteveBronder added 3 commits April 26, 2024 14:18

Merge remote-tracking branch 'origin/develop' into feature/reverse-mo…

7a9601d

…de-move-semantics

update to 5.0

d45dff2

fix docs

91ea4c1

SteveBronder and others added 2 commits May 31, 2024 12:33

Merge pull request #2928 from stan-dev/feature/reverse-mode-move-sema…

76d2a05

…ntics Allow arena_matrix to use move semantics

Merge remote-tracking branch 'origin/develop' into 5.0-breaking-changes

429dbc8

Merge remote-tracking branch 'origin' into 5.0-breaking-changes

243d90c

syclik approved these changes Jun 30, 2024

View reviewed changes

syclik merged commit 49b92b2 into develop Jun 30, 2024

5.0 breaking changes by SteveBronder · Pull Request #3050 · stan-dev/math · GitHub

Uh oh!

Uh oh!

5.0 breaking changes - #3050

5.0 breaking changes#3050
syclik merged 74 commits into
developfrom
5.0-breaking-changes

SteveBronder commented Apr 18, 2024 •
edited
Loading

Uh oh!

Uh oh!

SteveBronder commented Apr 18, 2024

Uh oh!

stan-buildbot commented Apr 19, 2024

Uh oh!

syclik commented Apr 19, 2024

Uh oh!

syclik commented Apr 19, 2024

Uh oh!

stan-buildbot commented May 3, 2024

Uh oh!

SteveBronder commented Jun 20, 2024

Uh oh!

stan-buildbot commented Jun 21, 2024

Uh oh!

syclik commented Jun 21, 2024

Uh oh!

SteveBronder commented Jun 21, 2024

Uh oh!

stan-buildbot commented Jun 21, 2024

Uh oh!

syclik left a comment

Uh oh!

syclik commented Jun 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

5.0 breaking changes by SteveBronder · Pull Request #3050 · stan-dev/math · GitHub

Uh oh!

Uh oh!

5.0 breaking changes - #3050

5.0 breaking changes#3050syclik merged 74 commits intodevelopstan-dev/math:developfrom 5.0-breaking-changesstan-dev/math:5.0-breaking-changesCopy head branch name to clipboard

Conversation

SteveBronder commented Apr 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Release notes

Checklist

Uh oh!

SteveBronder commented Apr 18, 2024

Uh oh!

stan-buildbot commented Apr 19, 2024

Uh oh!

syclik commented Apr 19, 2024

Uh oh!

syclik commented Apr 19, 2024

Uh oh!

stan-buildbot commented May 3, 2024

Uh oh!

SteveBronder commented Jun 20, 2024

Uh oh!

stan-buildbot commented Jun 21, 2024

Uh oh!

syclik commented Jun 21, 2024

Uh oh!

SteveBronder commented Jun 21, 2024

Uh oh!

stan-buildbot commented Jun 21, 2024

Uh oh!

syclik left a comment

Choose a reason for hiding this comment

Uh oh!

syclik commented Jun 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

5.0 breaking changes#3050
syclik merged 74 commits into
developfrom
5.0-breaking-changes

SteveBronder commented Apr 18, 2024 •
edited
Loading