FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Replace Boost numeric/odeint with existing SUNDIALS library by andrjohns · Pull Request #3357 · stan-dev/math · GitHub

/ math Public

Replace Boost numeric/odeint with existing SUNDIALS library - #3357

Open
andrjohns wants to merge 9 commits into
developfrom
boost-odeint
ConversationCommits (9)ChecksFiles changed
Open

Replace Boost numeric/odeint with existing SUNDIALS library#3357
andrjohns wants to merge 9 commits into
developfrom
boost-odeint

Conversation

andrjohns commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Summary

A companion to #3356, this PR replaces our dependency on the Boost numeric/odeint headers for the ode_rk45 and ode_ckrk functions with the ARKODE library from the SUNDIALS suite. The numeric/odeint headers brought in a massive footprint of files - namely the mpl and fusion libraries.

There are lots of file-changes due to the vendoring, but I've put that as a separate commit so it's easier to see just the Stan changes

Tests

N/A - existing tests should still pass

Side Effects

Slight reduction in compile times due to fewer includes

Release notes

Replaced the Boost odeint with ARKODE for the ode_rk45 and ode_ckrk functions

Checklist

  • Copyright holder: Andrew Johnson

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)

  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

stan-buildbot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor
Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_regr/gp_regr.stan 0.12 0.11 1.03 2.94% faster
gp_regr/gen_gp_data.stan 0.02 0.02 1.02 1.9% faster
arK/arK.stan 1.65 1.65 1.0 0.17% faster
eight_schools/eight_schools.stan 0.06 0.06 0.99 -0.6% slower
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 8.91 8.83 1.01 0.95% faster
pkpd/one_comp_mm_elim_abs.stan 20.44 20.46 1.0 -0.08% slower
pkpd/sim_one_comp_mm_elim_abs.stan 0.26 0.27 0.96 -3.7% slower
sir/sir.stan 78.84 112.44 0.7 -42.62% slower
gp_pois_regr/gp_pois_regr.stan 2.76 2.47 1.12 10.54% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.23 2.91 1.11 9.91% faster
irt_2pl/irt_2pl.stan 7.8 5.38 1.45 31.01% faster
arma/arma.stan 0.38 0.32 1.18 15.32% faster
garch/garch.stan 0.57 0.49 1.17 14.23% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.01 0.01 1.06 5.61% faster
performance.compilation 282.89 266.27 1.06 5.87% faster
Mean result: 1.0577041152587925

Jenkins Console Log
Blue Ocean
Commit hash: fb55e5ae8f992ecca9977e062d78369635037345

Machine information No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 80
On-line CPU(s) list: 0-79
Thread(s) per core: 2
Core(s) per socket: 20
Socket(s): 2
NUMA node(s): 2
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz
Stepping: 4
CPU MHz: 2400.000
CPU max MHz: 3700.0000
CPU min MHz: 1000.0000
BogoMIPS: 4800.00
Virtualization: VT-x
L1d cache: 1.3 MiB
L1i cache: 1.3 MiB
L2 cache: 40 MiB
L3 cache: 55 MiB
NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78
NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: KVM: Mitigation: Split huge pages
Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Mitigation; IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; IBRS; IBPB conditional; STIBP conditional; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Vmscape: Mitigation; IBPB before exit to userspace
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke md_clear flush_l1d arch_capabilities

G++:
g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Clang:
clang version 10.0.0-4ubuntu1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

WardBrian commented Aug 12, 2026

Copy link
Copy Markdown
Member

This needs to update https://github.com/stan-dev/math/blob/develop/lib/upgrade-sundials.sh#L117 to not delete the arkode files during sundials upgrades

andrjohns commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator Author

This needs to update https://github.com/stan-dev/math/blob/develop/lib/upgrade-sundials.sh#L117 to not delete the arkode files during sundials upgrades

Argh good catch! Updated the vendor script and re-written the history to run it and commit the results

SteveBronder commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Is everything up to 42a30df just upgrading sundials?

stan-buildbot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor
Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_regr/gp_regr.stan 0.12 0.12 0.97 -3.61% slower
gp_regr/gen_gp_data.stan 0.02 0.03 0.95 -4.77% slower
arK/arK.stan 1.66 1.77 0.94 -6.42% slower
eight_schools/eight_schools.stan 0.06 0.06 1.02 1.81% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 8.96 9.01 0.99 -0.62% slower
pkpd/one_comp_mm_elim_abs.stan 20.91 20.48 1.02 2.06% faster
pkpd/sim_one_comp_mm_elim_abs.stan 0.27 0.26 1.03 3.05% faster
sir/sir.stan 78.58 112.79 0.7 -43.52% slower
gp_pois_regr/gp_pois_regr.stan 2.75 2.44 1.13 11.4% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.09 2.94 1.05 5.1% faster
irt_2pl/irt_2pl.stan 6.62 5.71 1.16 13.76% faster
arma/arma.stan 0.38 0.46 0.83 -20.33% slower
garch/garch.stan 0.58 0.55 1.05 5.16% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.01 0.01 0.95 -4.82% slower
performance.compilation 282.08 294.25 0.96 -4.32% slower
Mean result: 0.9840462450866573

Jenkins Console Log
Blue Ocean
Commit hash: fb55e5ae8f992ecca9977e062d78369635037345

Machine information No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 80
On-line CPU(s) list: 0-79
Thread(s) per core: 2
Core(s) per socket: 20
Socket(s): 2
NUMA node(s): 2
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz
Stepping: 4
CPU MHz: 2400.000
CPU max MHz: 3700.0000
CPU min MHz: 1000.0000
BogoMIPS: 4800.00
Virtualization: VT-x
L1d cache: 1.3 MiB
L1i cache: 1.3 MiB
L2 cache: 40 MiB
L3 cache: 55 MiB
NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78
NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: KVM: Mitigation: Split huge pages
Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Mitigation; IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; IBRS; IBPB conditional; STIBP conditional; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Vmscape: Mitigation; IBPB before exit to userspace
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke md_clear flush_l1d arch_capabilities

G++:
g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Clang:
clang version 10.0.0-4ubuntu1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

andrjohns commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator Author

Is everything up to 42a30df just upgrading sundials?

Yep! Stan changes are only from 4cb6dff

stan-buildbot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor
Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_regr/gp_regr.stan 0.11 0.11 1.01 1.17% faster
gp_regr/gen_gp_data.stan 0.02 0.02 1.0 -0.42% slower
arK/arK.stan 1.71 1.66 1.03 3.25% faster
eight_schools/eight_schools.stan 0.06 0.06 0.97 -3.06% slower
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 8.94 8.96 1.0 -0.19% slower
pkpd/one_comp_mm_elim_abs.stan 20.49 20.45 1.0 0.21% faster
pkpd/sim_one_comp_mm_elim_abs.stan 0.26 0.26 0.99 -0.5% slower
sir/sir.stan 71.73 111.57 0.64 -55.54% slower
gp_pois_regr/gp_pois_regr.stan 2.82 2.53 1.11 10.29% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan 2.88 2.88 1.0 -0.1% slower
irt_2pl/irt_2pl.stan 5.62 5.4 1.04 3.94% faster
arma/arma.stan 0.32 0.32 1.01 0.95% faster
garch/garch.stan 0.49 0.47 1.04 4.05% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.01 0.01 1.04 3.97% faster
performance.compilation 295.53 277.94 1.06 5.95% faster
Mean result: 0.9973879260578039

Jenkins Console Log
Blue Ocean
Commit hash: 53b05f515233eacd215228b863f6706ec835030e

Machine information No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 80
On-line CPU(s) list: 0-79
Thread(s) per core: 2
Core(s) per socket: 20
Socket(s): 2
NUMA node(s): 2
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz
Stepping: 4
CPU MHz: 2400.000
CPU max MHz: 3700.0000
CPU min MHz: 1000.0000
BogoMIPS: 4800.00
Virtualization: VT-x
L1d cache: 1.3 MiB
L1i cache: 1.3 MiB
L2 cache: 40 MiB
L3 cache: 55 MiB
NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78
NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: KVM: Mitigation: Split huge pages
Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Mitigation; IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; IBRS; IBPB conditional; STIBP conditional; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Vmscape: Mitigation; IBPB before exit to userspace
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke md_clear flush_l1d arch_capabilities

G++:
g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Clang:
clang version 10.0.0-4ubuntu1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

andrjohns mentioned this pull request Aug 15, 2026
Closed
3 tasks

wds15 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

You upgraded Sundials - but did not go to the current 7.8.0 release? What was the rationale?

Don't get me wrong - this is not a must to go to the latest; just curious to know what the motivation is. Overall I think it is a good idea to move away from odeint in boost - as I recall the developer of odeint went to industry and is not super active in developing it. This is the status from a few years back.

andrjohns commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator Author

You upgraded Sundials - but did not go to the current 7.8.0 release? What was the rationale?

Don't get me wrong - this is not a must to go to the latest; just curious to know what the motivation is. Overall I think it is a good idea to move away from odeint in boost - as I recall the developer of odeint went to industry and is not super active in developing it. This is the status from a few years back.

Oh I just added the extraction of ARKODES from the current version, I hadn't updated the version. Do you think it's worth bumping the version as well?

wds15 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Moving along the version gives one the benefit of a maintained software. I looked into it a while ago (pre Claude) and found it was a hassle as a few things changed. I'd think that it is a good thing to move along, yes. Sundials does not need the overall frequently, but now is certainly a good time... though to keep the PR reviewable I would not suggest to fold it into here.

SteveBronder commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

@dylex is the error we are seeing here because of the jenkins migration?

https://jenkins-new.flatironinstitute.org/job/CCM/job/Stan/job/math/job/PR-3357/2/

WardBrian commented Aug 25, 2026

Copy link
Copy Markdown
Member

Until #3360 is merged you don’t want to look at Jenkins-new

https://jenkins.flatironinstitute.org/job/Stan/job/Math/view/change-requests/job/PR-3357/10/ Passed

SteveBronder self-assigned this Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

SteveBronder

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL