FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Migration to new jenkins by dylex · Pull Request #3360 · stan-dev/math · GitHub

/ math Public

Migration to new jenkins - #3360

Open
dylex wants to merge 5 commits into
developfrom
jenkins-new
ConversationCommits (5)ChecksFiles changed
Open

Migration to new jenkins#3360
dylex wants to merge 5 commits into
developfrom
jenkins-new

Conversation

dylex commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Migration to jenkins-new, significant cleanup of Jenkinsfile, mostly the same behaviors.

  • Replace downstream_ branches (on stan) with downstream parameter
  • Replace use of stanorg/ci:gpu-cpp17 image with local Dockerfile, mainly an optimized image with a few unnecessary things removed and updates to build correctly

WardBrian previously approved these changes Aug 24, 2026
View reviewed changes

WardBrian left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Overall looks great, thanks!

I didn't see a run that actually built the distribution tests, so I've kicked off https://jenkins-new.flatironinstitute.org/job/CCM/job/Stan/job/math/job/jenkins-new/16/ to test

I'd also like to perhaps move the docker images back to one centralized place, especially since they would ideally also be used by stanc3: https://github.com/stan-dev/stanc3/blob/90c653249048b3aaa04bd488fcf20dceebeeda62/Jenkinsfile#L166
But that can be done post-merge

Comment thread Jenkinsfile Outdated

dylex commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator Author

One complication to keep in mind for the Dockerfiles is that there are (at least) two different versions being used: stanorg/ci:gpu, which is based on an old version of Dockerfile-gpu before clang was updated to 7 (possibly https://github.com/stan-dev/ci-scripts/blob/b57fa182797941f87a92d509da9121952ac60cc0/docker/ci/Dockerfile-gpu) and stanorg/ci:gpu-cpp17 which is at least closer to the current version. Only math uses the new version as far as I can tell, and the others use the old one.

It's definitely possible to use a Dockerfile from a submodule or different repo, if we want.

WardBrian commented Aug 24, 2026

Copy link
Copy Markdown
Member

@dylex understood -- I think it would be fine (probably even preferrable) if everything used the same image that Math does

WardBrian previously approved these changes Aug 24, 2026
View reviewed changes

WardBrian commented Aug 24, 2026

Copy link
Copy Markdown
Member

(I'd still like to see a run that does all the distribution tests before merging, if one exists)

WardBrian mentioned this pull request Aug 25, 2026
Open
4 tasks
dylex force-pushed the jenkins-new branch 4 times, most recently from 0832578 to 0b26bcd Compare August 26, 2026 18:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

WardBrian WardBrian left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL