FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add C implementation for arcsine CDF by Planeshifter · Pull Request #3354 · stdlib-js/stdlib · GitHub

/ stdlib Public

feat: add C implementation for arcsine CDF - #3354

Merged
kgryte merged 8 commits into
developfrom
philipp/arcsine-cdf-c-api
Dec 11, 2024
ConversationCommits (8)ChecksFiles changed
Merged

feat: add C implementation for arcsine CDF#3354
kgryte merged 8 commits into
developfrom
philipp/arcsine-cdf-c-api

Conversation

Planeshifter commented Dec 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Resolves #3384 .

Description

What is the purpose of this pull request?

This pull request:

  • Adds a C implementation of the arcsine cumulative distribution function (CDF).
  • Includes benchmarks for the C implementation.
  • Provides examples demonstrating the usage of the arcsine CDF in C.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

stdlib-bot commented Dec 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/arcsine/cdf $\color{green}317/317$
$\color{green}+100.00\%$ 		$\color{green}27/27$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}317/317$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Planeshifter commented Dec 7, 2024

Copy link
Copy Markdown
Member Author

/stdlib update-copyright-years

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 7, 2024
stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 7, 2024
Planeshifter mentioned this pull request Dec 7, 2024
Merged
1 task
Planeshifter marked this pull request as ready for review December 7, 2024 14:03
Planeshifter requested a review from kgryte December 7, 2024 14:03
stdlib-bot added the Needs Review A pull request which needs code review. label Dec 7, 2024
kgryte added Feature Issue or pull request for adding a new feature. Statistics Issue or pull request related to statistical functionality. labels Dec 11, 2024

kgryte commented Dec 11, 2024

Copy link
Copy Markdown
Member

This PR is also missing benchmark.native.js.

This was referenced Dec 11, 2024
Closed
Closed
Closed
stdlib-bot mentioned this pull request Dec 11, 2024
Closed
3 tasks
Planeshifter and others added 2 commits December 10, 2024 21:02
chore: move number generation to function
da14b77 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
chore: apply suggestions and add benchmark.native.js
b5cd4af
This was referenced Dec 13, 2024
Open
Closed
Closed
Closed
Open
Closed
Closed
Open
Open
Open
kgryte reviewed Dec 13, 2024
View reviewed changes
Comment thread lib/node_modules/@stdlib/stats/base/dists/arcsine/cdf/benchmark/benchmark.native.js

// MAIN //

bench( pkg, opts, function benchmark( b ) {

kgryte Dec 13, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is missing pkg+'::native'.

manvith2003 mentioned this pull request Dec 15, 2024
Merged
1 task
anandkaranubc mentioned this pull request Jan 10, 2025
Closed
1 task
This was referenced Jan 24, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 31, 2025
Closed
Closed
Closed
anandkaranubc mentioned this pull request Feb 25, 2025
Closed
2 tasks
rautelaKamal mentioned this pull request Mar 3, 2026
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kgryte kgryte approved these changes

Assignees

No one assigned

Labels

Feature Issue or pull request for adding a new feature. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/arcsine/cdf

3 participants

Back | FazBrowse Home | New Git URL