FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add C implementation for `stats/base/dists/normal/cdf` by manvith2003 · Pull Request #3911 · stdlib-js/stdlib · GitHub

/ stdlib Public

feat: add C implementation for stats/base/dists/normal/cdf - #3911

Merged
Planeshifter merged 10 commits into
stdlib-js:developfrom
manvith2003:normal_cdf
Jun 18, 2025
ConversationCommits (10)ChecksFiles changed
Merged

feat: add C implementation for stats/base/dists/normal/cdf#3911
Planeshifter merged 10 commits into
stdlib-js:developfrom
manvith2003:normal_cdf

Conversation

manvith2003 commented Dec 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Resolves ##3771

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for @stdlib/stats/base/dists/normal/cdf along with relevant docs, tests, examples and benchmarks.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 14, 2024

stdlib-bot commented Dec 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/normal/cdf $\color{green}299/299$
$\color{green}+100.00\%$ 		$\color{green}25/25$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}299/299$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

manvith2003 commented Dec 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@Planeshifter @kgryte

I am encountering an issue while running the JavaScript benchmark command for the CDF of a normal distribution.

make benchmark-javascript-files FILES="/Users/pgb/stdlib/lib/node_modules/@stdlib/stats/base/dists/normal/cdf/benchmark/benchmark.native.js"

A similar issue also occurs when running the JavaScript benchmark for the CDF of an arcsine distribution which was the reference PR for the current PR feat: add C implementation for arcsine CDF #3354

Can you please help me resolve this?

Planeshifter changed the title feat: add C implementation for @stdlib/stats/base/dists/normal/cdf feat: add C implementation for stats/base/dists/normal/cdf Dec 15, 2024

kgryte commented Dec 15, 2024

Copy link
Copy Markdown
Member

@manvith2003 What is the issue? Can you provide a screenshot? One thing is that you need to have first compiled the package's native add-on before you can run the benchmarks.

manvith2003 commented Dec 15, 2024

Copy link
Copy Markdown
Contributor Author

@kgryte

I have first compiled the package's native add-on before running the benchmarks.

Planeshifter commented Dec 15, 2024 •
edited by kgryte
Loading

Copy link
Copy Markdown
Member

@manvith2003

Sorry for the confusion, the command in the issues is incorrect since it uses a hard-coded path from my system. The correct command is

make benchmark-javascript-files FILES="$(pwd)/lib/node_modules/@stdlib/stats/base/dists/normal/cdf/benchmark/benchmark.native.js"

so that it uses your current working directory (via pwd). I will be looking into updating the issues with the correct command.

Updated: I (Athan) updated this comment and the suggested command to fix a typo.

manvith2003 commented Dec 16, 2024

Copy link
Copy Markdown
Contributor Author

@Planeshifter @kgryte

After the running the new command also encountering same issue

kgryte commented Dec 16, 2024

Copy link
Copy Markdown
Member

@manvith2003 That is because @Planeshifter's suggestion is still incorrect. From the root project directory,

make benchmark-javascript-files FILES="$(pwd)/lib/node_modules/@stdlib/stats/base/dists/normal/cdf/benchmark/benchmark.native.js"

I suggest studying the other suggested commands next time and seeing what is different. You likely could have deduced the above by examining the paths and seeing what is different from what you were attempting to run.

manvith2003 commented Dec 16, 2024

Copy link
Copy Markdown
Contributor Author

@kgryte

Noted, I’ll review more carefully next time. Thanks!

Planeshifter commented Apr 2, 2025

Copy link
Copy Markdown
Member

/stdlib update-copyright-years

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 2, 2025
stdlib-bot added Good First PR A pull request resolving a Good First Issue. and removed bot: In Progress Pull request is currently awaiting automation. labels Apr 2, 2025
Planeshifter added the bot: Update Copyright Years Pull request needing the copyright years of its files updated. label May 10, 2025
stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: Update Copyright Years Pull request needing the copyright years of its files updated. labels May 10, 2025
kgryte removed the bot: In Progress Pull request is currently awaiting automation. label Jun 17, 2025

kgryte commented Jun 17, 2025

Copy link
Copy Markdown
Member

/stdlib merge

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jun 17, 2025
kgryte requested a review from Planeshifter June 17, 2025 09:50
stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jun 17, 2025
bench: remove unused require
1f20141 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
chore: reorder variable declarations
d607719 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
chore: minor clean-up
c6bf38a 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter approved these changes Jun 18, 2025
View reviewed changes

Planeshifter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks, @manvith2003!

stdlib-bot removed the Needs Review A pull request which needs code review. label Jun 18, 2025

stdlib-bot commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/normal/cdf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3911
Ref: https://github.com/stdlib-js/stdlib/issues/3771

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

Planeshifter merged commit c5bcc23 into stdlib-js:develop Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/normal/cdf

4 participants

Back | FazBrowse Home | New Git URL