FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Variant addition: Nucleo-64 L412RB_P by askuric · Pull Request #2713 · stm32duino/Arduino_Core_STM32 · GitHub

/ Arduino_Core_STM32 Public

Variant addition: Nucleo-64 L412RB_P - #2713

Merged
fpistm merged 8 commits into
stm32duino:mainfrom
askuric:variant_l412rbp
Apr 22, 2025
ConversationCommits (8)ChecksFiles changed
Merged

Variant addition: Nucleo-64 L412RB_P#2713
fpistm merged 8 commits into
stm32duino:mainfrom
askuric:variant_l412rbp

Conversation

askuric commented Apr 17, 2025

Copy link
Copy Markdown
Contributor

Summary

This PR adds the support for the nucleo l412rb_p variant.
And for the generic family associated with it (L412RBIxP and L412RBTxP)

It is realted to these issues:

Which have been merged within this issue:

Validation

  • The code has been tested using the CheckVariant example:

The built-in led blinks and this is the serial output:

####
NUM_DIGITAL_PINS = 50
NUM_ANALOG_INPUTS = 13
#####
Checking digital pins...
End check digital pins
#####
Checking analog pins definition...
End check analog pins
#####
Checking IP instances (I2C, UART, SPI)...
End check IP instances (I2C, UART, SPI)

########################################
#### Test PASSED
########################################
  • The nucleo has been tested using SimpleFOC library (ADC+PWMs) and everything seems to work well.

Code formatting

I'm happy to adapt it to your requirements if needed.

fpistm self-requested a review April 17, 2025 10:12
fpistm requested changes Apr 17, 2025
View reviewed changes

fpistm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hi @askuric
Thanks the PR. Nice job.
Small comments to fix and ideally would prefers 2 commits one for the generic part and one for the variants.

Comment thread README.md Outdated
Comment thread boards.txt Outdated
Comment thread variants/STM32L4xx/L412RB(I-T)xP/ldscript.ld Outdated
Comment thread variants/STM32L4xx/L412RB(I-T)xP/ldscript.ld Outdated
This was linked to issues Apr 17, 2025
Add board NUCLEO L412RB-P #1350
Closed
[New Variant] NUCLEO-L412RB-P #2663
Closed
fpistm requested changes Apr 17, 2025
View reviewed changes
Comment thread variants/STM32L4xx/L412RB(I-T)xP/variant_NUCLEO_L412RB_P.h Outdated
askuric and others added 4 commits April 22, 2025 09:10
readme update
a96f357
Apply suggestions from code review
10e198e 
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Antun Skuric <36178713+askuric@users.noreply.github.com>
boardes.txt removed newline at the end
235ed67
boardes.txt removed newline at the end
a2beeba

askuric commented Apr 22, 2025

Copy link
Copy Markdown
Contributor Author

Hi @fpistm,

Thanks for the comments.
I've just realised that when I apply the changes you suggested the comments disappear as well.

The changes that I've done:

  • Updated readme to remove the change of the unrealted board
  • Updated the boards.txt to remove the end of file change (missing empty line at the end)

Accepted the changes

  • memory ld file: I've used the stock file generated by CubeMX, I did not necessary have a use for the RAM2, that's how CubeMX generated the file. So if you want me to remove it let me know. :D
  • TIM7 used but not defined: I've used the nucleo_l433rc_p files as a template for this l412rb_p as they belong to the same family of nucleos-64. As I ran the examples and I did not see any errors I did not catch this issue and the TIM7 stayed.

How did you test the variant?
I've tested it using Arduino IDE, I've changed the files in the arduino board packages and used the checkvariant example link (I've copied it in the arduino sketch and run it on the nucleo board).
Also, I've used SimpleFOC and run a code turning a motor on the nucleo and measuring the currents. Which worked well.

Is there a better way of testing. I'm planning to add two more nucleo-64 variants in the next few days so if you have some suggestions, please let me know :D

fpistm commented Apr 22, 2025

Copy link
Copy Markdown
Member

Is there a better way of testing. I'm planning to add two more nucleo-64 variants in the next few days so if you have some suggestions, please let me know :D

No it is a good way to test the variant and its definitnion. As said, it is really strange you didn't see the build issue, maybe an issue in the selected target.

fpistm approved these changes Apr 22, 2025
View reviewed changes

fpistm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

askuric commented Apr 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Ok that's interesting. Now I'm having some issues with the build with the latest changes.
When I build and upload the code to the board I get the FAIL.txt file which says:

The application file format is unknown and cannot be parsed and/or processed

I think that my lack of experience is catching up with my initial luck. :D
Let me do some more testing and come back to you.

fpistm commented Apr 22, 2025

Copy link
Copy Markdown
Member 
The application file format is unknown and cannot be parsed and/or processed

Try to update the STLink firmware using the STM32Cube programmer thanks the "Firmware upgrade" button.

askuric commented Apr 22, 2025

Copy link
Copy Markdown
Contributor Author

Try to update the STLink firmware using the STM32Cube programmer thanks the "Firmware upgrade" button.

I've tried this and it did not make any difference.
But what did make a difference is to put the Upload method to STM32CubeProgrammer (SWD) and not Mass storage. :D
With the SWD I have no more issues and everything works well.

Is this a red flag or is it normal?

Additionally, I've run some more tests, so far I've tested:

  • Timers
  • ADC
  • SPI
  • Pin names (as I'm using Arduino UNO R3 header names)

And everything seems to work as expected.

fpistm commented Apr 22, 2025

Copy link
Copy Markdown
Member

If swd works it is linked to the Stlink firmware which provides the mass storage storage.
No link with the binary

askuric commented Apr 22, 2025

Copy link
Copy Markdown
Contributor Author

So then it's an issue with my setup, not the variant files right?
So the PR is ok?

fpistm commented Apr 22, 2025

Copy link
Copy Markdown
Member

Unfortunately, I do not have this board to test anyway from my point of view the PR is ok.

fpistm added the new variant Add support of new bard label Apr 22, 2025
fpistm added this to the 2.11.0 milestone Apr 22, 2025
fpistm mentioned this pull request Apr 22, 2025
Open
93 tasks
fpistm merged commit fddfdeb into stm32duino:main Apr 22, 2025
github-project-automation Bot moved this from In progress to Done in STM32 core based on ST HAL Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

fpistm fpistm approved these changes

Assignees

No one assigned

Labels

new variant Add support of new bard

Projects

STM32 core based on ST HAL
Status: Done

Milestone

2.11.0

Development

Successfully merging this pull request may close these issues.

[New Variant] NUCLEO-L412RB-P Add board NUCLEO L412RB-P

2 participants

Back | FazBrowse Home | New Git URL