FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: pass updated keyword args to Publisher/Subscriber client in google/pubsub #161 by Mohsin-Ul-Islam · Pull Request #164 · testcontainers/testcontainers-python · GitHub

fix: pass updated keyword args to Publisher/Subscriber client in google/pubsub #161 - #164

Merged
alexanderankin merged 2 commits into
testcontainers:mainfrom
Mohsin-Ul-Islam:fix-google-cloud-pubsub
Mar 30, 2024
Merged

fix: pass updated keyword args to Publisher/Subscriber client in google/pubsub #161#164
alexanderankin merged 2 commits into
testcontainers:mainfrom
Mohsin-Ul-Islam:fix-google-cloud-pubsub

Conversation

Copy link
Copy Markdown
Contributor

…le/pubsub

Mohsin-Ul-Islam force-pushed the fix-google-cloud-pubsub branch from 5137180 to 9039344 Compare May 9, 2022 05:50
Mohsin-Ul-Islam force-pushed the fix-google-cloud-pubsub branch from 9039344 to 7717d76 Compare May 22, 2022 12:24

codecov-commenter commented May 22, 2022
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@8fb4bcc). Click here to learn what that means.

❗ Current head 7717d76 differs from pull request most recent head 71e1080. Consider uploading reports for the commit 71e1080 to get more accurate results

Files Patch % Lines
testcontainers/google/pubsub.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #164   +/-   ##
=======================================
  Coverage        ?   82.57%           
=======================================
  Files           ?       26           
  Lines           ?      706           
  Branches        ?       65           
=======================================
  Hits            ?      583           
  Misses          ?      103           
  Partials        ?       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

Seems like another fix could be a #446 release

alexanderankin added 👥 community feat feature but its a community module so we wont bump tc core for it and removed 👀 requires attention labels Mar 26, 2024
alexanderankin changed the title fix: pass updated keyword args to Publisher/Subscriber client in goog… #161 fix: pass updated keyword args to Publisher/Subscriber client in google/pubsub #161 Mar 30, 2024
alexanderankin force-pushed the fix-google-cloud-pubsub branch from 7717d76 to c289c34 Compare March 30, 2024 22:38
alexanderankin merged commit 8addc11 into testcontainers:main Mar 30, 2024
Mohsin-Ul-Islam deleted the fix-google-cloud-pubsub branch March 30, 2024 23:35
alexanderankin pushed a commit that referenced this pull request Apr 1, 2024
🤖 I have created a release *beep* *boop*
---


##
[4.3.0](testcontainers-v4.2.0...testcontainers-v4.3.0)
(2024-04-01)


### Features

* **client:** Add custom User-Agent in Docker client as
`tc-python/<version>`
([#507](#507))
([dd55082](dd55082))


### Bug Fixes

* Add CassandraContainer
([#476](#476))
([507e466](507e466))
* add chroma container
([#515](#515))
([0729bf4](0729bf4))
* Add Weaviate module
([#492](#492))
([90762e8](90762e8))
* **cassandra:** make cassandra dependency optional/test-only
([#518](#518))
([bddbaeb](bddbaeb))
* **core:** allow setting docker command path for docker compose
([#512](#512))
([63fcd52](63fcd52))
* **google:** add support for Datastore emulator
([#508](#508))
([3d891a5](3d891a5))
* Improved Oracle DB module
([#363](#363))
([6e6d8e3](6e6d8e3))
* inconsistent test runs for community modules
([#497](#497))
([914f1e5](914f1e5))
* **kafka:** Add redpanda testcontainer module
([#441](#441))
([451d278](451d278))
* **kafka:** wait_for_logs in kafka container to reduce lib requirement
([#377](#377))
([909107b](909107b))
* **keycloak:** container should use dedicated API endpoints to
determine container readiness
([#490](#490))
([2e27225](2e27225))
* **nats:** Client-Free(ish) NATS container
([#462](#462))
([302c73d](302c73d))
* **new:** add a new Docker Registry test container
([#389](#389))
([0f554fb](0f554fb))
* pass doctests, s/doctest/doctests/, run them in gha,
s/asyncpg/psycopg/ in doctest, fix keycloak flakiness: wait for first
user
([#505](#505))
([545240d](545240d))
* pass updated keyword args to Publisher/Subscriber client in
google/pubsub
[#161](#161)
([#164](#164))
([8addc11](8addc11))
* Qdrant module
([#463](#463))
([e8876f4](e8876f4))
* remove accidentally added pip in dev dependencies
([#516](#516))
([dee20a7](dee20a7))
* **ryuk:** Enable Ryuk test suite. Ryuk image 0.5.1 -> 0.7.0. Add
RYUK_RECONNECTION_TIMEOUT env variable
([#509](#509))
([472b2c2](472b2c2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👥 community feat feature but its a community module so we wont bump tc core for it 📦 package: google

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL