FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Add CassandraContainer by cbornet · Pull Request #476 · testcontainers/testcontainers-python · GitHub

fix: Add CassandraContainer - #476

Merged
alexanderankin merged 3 commits into
testcontainers:mainfrom
cbornet:cassandra
Mar 31, 2024
Merged

fix: Add CassandraContainer#476
alexanderankin merged 3 commits into
testcontainers:mainfrom
cbornet:cassandra

Conversation

cbornet commented Mar 14, 2024

Copy link
Copy Markdown
Contributor

No description provided.

cbornet changed the title Add CassandraContainer feat: Add CassandraContainer Mar 15, 2024
self.with_exposed_ports(self.port)

def _connect(self):
wait_for_logs(self, "Startup complete")

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What is the preferred strategy for the readiness probe ?
I have used wait_for_logs here because it doesn't need to depend on the cassandra driver.
But I see that the Java implementation uses the driver and it gives the opportunity to provide an init script.

alexanderankin commented Mar 20, 2024
edited
Loading

Copy link
Copy Markdown
Member

there is work on going here #167 (comment) too

cbornet commented Mar 20, 2024

Copy link
Copy Markdown
Contributor Author

Oh, sorry I missed that ! The PR has been opened for more than 2 years ?!
Feel free to merge any of them. With your latest fruch@2b238a2 they are very similar.
Some differences to note:

  • This one doesn't depend on the cassandra driver. It exposes a contact points tuple instead of a Cluster(). The tuple can be fed directly to a Cluster constructor.
  • This one adds an entry in .github/settings.xml

alexanderankin added the 👥 community feat feature but its a community module so we wont bump tc core for it label Mar 26, 2024
alexanderankin force-pushed the cassandra branch 2 times, most recently from dacdbca to 4e4fa41 Compare March 31, 2024 00:07
alexanderankin changed the title feat: Add CassandraContainer fix: Add CassandraContainer Mar 31, 2024
alexanderankin merged commit 507e466 into testcontainers:main Mar 31, 2024
alexanderankin pushed a commit that referenced this pull request Apr 1, 2024
🤖 I have created a release *beep* *boop*
---


##
[4.3.0](testcontainers-v4.2.0...testcontainers-v4.3.0)
(2024-04-01)


### Features

* **client:** Add custom User-Agent in Docker client as
`tc-python/<version>`
([#507](#507))
([dd55082](dd55082))


### Bug Fixes

* Add CassandraContainer
([#476](#476))
([507e466](507e466))
* add chroma container
([#515](#515))
([0729bf4](0729bf4))
* Add Weaviate module
([#492](#492))
([90762e8](90762e8))
* **cassandra:** make cassandra dependency optional/test-only
([#518](#518))
([bddbaeb](bddbaeb))
* **core:** allow setting docker command path for docker compose
([#512](#512))
([63fcd52](63fcd52))
* **google:** add support for Datastore emulator
([#508](#508))
([3d891a5](3d891a5))
* Improved Oracle DB module
([#363](#363))
([6e6d8e3](6e6d8e3))
* inconsistent test runs for community modules
([#497](#497))
([914f1e5](914f1e5))
* **kafka:** Add redpanda testcontainer module
([#441](#441))
([451d278](451d278))
* **kafka:** wait_for_logs in kafka container to reduce lib requirement
([#377](#377))
([909107b](909107b))
* **keycloak:** container should use dedicated API endpoints to
determine container readiness
([#490](#490))
([2e27225](2e27225))
* **nats:** Client-Free(ish) NATS container
([#462](#462))
([302c73d](302c73d))
* **new:** add a new Docker Registry test container
([#389](#389))
([0f554fb](0f554fb))
* pass doctests, s/doctest/doctests/, run them in gha,
s/asyncpg/psycopg/ in doctest, fix keycloak flakiness: wait for first
user
([#505](#505))
([545240d](545240d))
* pass updated keyword args to Publisher/Subscriber client in
google/pubsub
[#161](#161)
([#164](#164))
([8addc11](8addc11))
* Qdrant module
([#463](#463))
([e8876f4](e8876f4))
* remove accidentally added pip in dev dependencies
([#516](#516))
([dee20a7](dee20a7))
* **ryuk:** Enable Ryuk test suite. Ryuk image 0.5.1 -> 0.7.0. Add
RYUK_RECONNECTION_TIMEOUT env variable
([#509](#509))
([472b2c2](472b2c2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
cbornet deleted the cassandra branch April 2, 2024 15:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👥 community feat feature but its a community module so we wont bump tc core for it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL